Re: [GIT PULL 3/6] KVM: x86: Use file_to_kvm_x86() in SEV

[Christian Borntraeger <borntraeger@linux.ibm.com>]

Am 09.10.26 um 16:36 schrieb sashiko-bot@kernel.org:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Low] kvm: build failure due to missing definition of file_to_kvm_x86()
> --
> 
> commit 10a7cd7a1613201c02ffd0500ecb15453fab9d30
> Author: Steffen Eiden <seiden@linux.ibm.com>
> 
> KVM: x86: Use file_to_kvm_x86() in SEV
> 
> This commit replaces the open-coded file check and private_data cast
> with a new arch-namespaced helper file_to_kvm_x86().
> 
>> diff --git a/arch/x86/kvm/svm/sev.c b/arch/x86/kvm/svm/sev.c
>> index 944aaea6501f2..2787b832c9e0f 100644
>> --- a/arch/x86/kvm/svm/sev.c
>> +++ b/arch/x86/kvm/svm/sev.c
>> @@ -2121,10 +2121,10 @@ int sev_vm_move_enc_context_from(struct kvm *kvm, unsigned int source_fd)
>>   	if (fd_empty(f))
>>   		return -EBADF;
>>   
>> -	if (!file_is_kvm(fd_file(f)))
>> +	source_kvm = file_to_kvm_x86(fd_file(f));
> 
> [Severity: Low]
> Is file_to_kvm_x86() defined anywhere in the kernel source tree at this
> commit? It appears to be missing, which will cause an implicit
> declaration compiler error here in sev_vm_move_enc_context_from().
> Could it be that the patch introducing this helper was omitted from the
> series or ordered after this patch?

false positive, see patch1.