From: Karsten Graul <kgraul@linux.ibm.com>
To: Wen Gu <guwen@linux.alibaba.com>, davem@davemloft.net, kuba@kernel.org
Cc: linux-s390@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net v4] net/smc: Reset conn->lgr when link group registration fails
Date: Thu, 6 Jan 2022 11:00:12 +0100 [thread overview]
Message-ID: <96521e26-7d51-7451-3cf4-cca37da9dc24@linux.ibm.com> (raw)
In-Reply-To: <1641451455-41647-1-git-send-email-guwen@linux.alibaba.com>
On 06/01/2022 07:44, Wen Gu wrote:
> @@ -630,10 +630,11 @@ static int smc_connect_decline_fallback(struct smc_sock *smc, int reason_code,
>
> static void smc_conn_abort(struct smc_sock *smc, int local_first)
> {
> + struct smc_connection *conn = &smc->conn;
> +
> + smc_conn_free(conn);
> if (local_first)
> - smc_lgr_cleanup_early(&smc->conn);
> - else
> - smc_conn_free(&smc->conn);
> + smc_lgr_cleanup_early(conn->lgr);
> }
Looks like I missed a prereq patch here, but wo'nt conn->lgr be set to NULL
after smc_conn_free() called smc_lgr_unregister_conn()?
next prev parent reply other threads:[~2022-01-06 10:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-06 6:44 [PATCH net v4] net/smc: Reset conn->lgr when link group registration fails Wen Gu
2022-01-06 10:00 ` Karsten Graul [this message]
2022-01-06 11:33 ` Wen Gu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=96521e26-7d51-7451-3cf4-cca37da9dc24@linux.ibm.com \
--to=kgraul@linux.ibm.com \
--cc=davem@davemloft.net \
--cc=guwen@linux.alibaba.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox