Re: [PATCH net v6] net/smc: fix lgr/lnk lifetime vs diag reader race

[Mahanta Jambigi <mjambigi@linux.ibm.com>]

On 30/09/26 6:21 am, netdev-bot+sashiko@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 4 potential
> issue(s) to consider.
> 
> Critical: 0 · High: 1 · Medium: 2 (1) · Low: 1
> 
> If you believe none of the issues are legitimate, please reply to each
> issue of Medium severity or higher and explain why the AI is wrong.
> If any of them are legitimate and you plan to respin, please let patchwork
> know by including "pw-bot: cr" as a separate line at the end of your reply
> (one such reply per series is enough).
> 
> - [High] The patch leaves open another window of the class it says it
>   closes ('a hashed socket has freed or partially freed conn/lgr/lnk…
> - [Medium] The new early exit in __smc_diag_dump()
>   (net/smc/smc_diag.c:107-108, `if (sk->sk_state == SMC_INIT ||…
> - [Medium] For the smc_conn_abort() path, the patch's only protection
>   against dereferencing a freed conn->lgr in __smc_diag_dump() is two…
> - [Low] The second race the patch fixes is smcd_buf_detach() freeing
>   conn->sndbuf_desc in smc_conn_kill() while the socket is hashed and…
> 
> Pre-existing issues:
> - [Medium] This problem wasn't introduced by this patch, but
>   smc_diag_handler_dump() (net/smc/smc_diag.c:245-260) starts the dump…

I'll address the applicable issues in v7. I missed the following line in
my previous reply:

pw-bot: cr