From: Tillmann Heidsieck <theidsieck@leenox.de>
To: Alexander Kuleshov <kuleshovmail@gmail.com>
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
linux390@de.ibm.com, linux-s390@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-kernel-owner@vger.kernel.org
Subject: Re: [PATCH] s390/jump_label: Use %*ph to print small buffers
Date: Wed, 26 Aug 2015 21:03:00 +0200 [thread overview]
Message-ID: <9ca5f3280075e7b94356003e250efe25@mail.leenox.de> (raw)
In-Reply-To: <1440614969-11351-1-git-send-email-kuleshovmail@gmail.com>
Hi Alexander,
On 2015-08-26 20:49, Alexander Kuleshov wrote:
> printk() supports %*ph format specifier for printing a small buffers,
> let's use it intead of %02x %02x...
noble effort ...
> pr_emerg("Jump label code mismatch at %pS [%p]\n", ipc, ipc);
> - pr_emerg("Found: %02x %02x %02x %02x %02x %02x\n",
> + pr_emerg("Found: %6ph\n",
> ipc[0], ipc[1], ipc[2], ipc[3], ipc[4], ipc[5]);
> - pr_emerg("Expected: %02x %02x %02x %02x %02x %02x\n",
> + pr_emerg("Expected: %6ph\n",
> ipe[0], ipe[1], ipe[2], ipe[3], ipe[4], ipe[5]);
> - pr_emerg("New: %02x %02x %02x %02x %02x %02x\n",
> + pr_emerg("New: %6ph\n",
> ipn[0], ipn[1], ipn[2], ipn[3], ipn[4], ipn[5]);
> panic("Corrupted kernel text");
> }
... but you might want to check our code before submission (e.g. compile
it!)
Cheers
Tillmann
next prev parent reply other threads:[~2015-08-26 19:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-26 18:49 [PATCH] s390/jump_label: Use %*ph to print small buffers Alexander Kuleshov
2015-08-26 19:03 ` Tillmann Heidsieck [this message]
2015-08-26 19:12 ` Alexander Kuleshov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9ca5f3280075e7b94356003e250efe25@mail.leenox.de \
--to=theidsieck@leenox.de \
--cc=heiko.carstens@de.ibm.com \
--cc=kuleshovmail@gmail.com \
--cc=linux-kernel-owner@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux390@de.ibm.com \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox