From: Janosch Frank <frankja@linux.ibm.com>
To: Claudio Imbrenda <imbrenda@linux.ibm.com>
Cc: kvm@vger.kernel.org, linux-s390@vger.kernel.org,
thuth@redhat.com, david@redhat.com, nsg@linux.ibm.com,
nrb@linux.ibm.com
Subject: Re: [kvm-unit-tests RFC 2/3] lib: s390x: sclp: Clear ASCII screen on setup
Date: Mon, 3 Jul 2023 14:30:56 +0200 [thread overview]
Message-ID: <9d78e1d8-190c-a06b-751c-a13721e08a35@linux.ibm.com> (raw)
In-Reply-To: <20230703135758.19a7c5fd@p-imbrenda>
On 7/3/23 13:57, Claudio Imbrenda wrote:
> On Mon, 3 Jul 2023 13:36:05 +0200
> Janosch Frank <frankja@linux.ibm.com> wrote:
>
>> On 6/30/23 17:25, Claudio Imbrenda wrote:
>>> On Fri, 30 Jun 2023 14:54:48 +0000
>>> Janosch Frank <frankja@linux.ibm.com> wrote:
>>>
>>>> In contrast to the line-mode console the ASCII console will retain
>>>
>>> what's the problem with that?
>>
>> It can be a bit hard to read since you need to find the line where the
>> old output ends and the new one starts.
>>
>>
>> I don't insist on this patch being included, the \r and sclp line mode
>> input patches give me enough usability.
>
> make it a compile-time option? (default off)
>
> then you won't need to change the run script, and you can still clear
> the console when you need it (HMC)
Well, the compile-time check made me remember that we have
lib/s390x/hardware.c. We can simply check for HOST_IS_LPAR and clear
accordingly.
next prev parent reply other threads:[~2023-07-03 12:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-30 14:54 [kvm-unit-tests RFC 0/3] s390x: Improve console handling Janosch Frank
2023-06-30 14:54 ` [kvm-unit-tests RFC 1/3] lib: s390x: sclp: Add carriage return to line feed Janosch Frank
2023-06-30 15:12 ` Claudio Imbrenda
2023-07-03 11:46 ` Janosch Frank
2023-07-03 12:04 ` Claudio Imbrenda
2023-06-30 14:54 ` [kvm-unit-tests RFC 2/3] lib: s390x: sclp: Clear ASCII screen on setup Janosch Frank
2023-06-30 15:25 ` Claudio Imbrenda
2023-07-03 11:36 ` Janosch Frank
2023-07-03 11:57 ` Claudio Imbrenda
2023-07-03 12:30 ` Janosch Frank [this message]
2023-06-30 14:54 ` [kvm-unit-tests RFC 3/3] lib: s390x: sclp: Add line mode input handling Janosch Frank
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9d78e1d8-190c-a06b-751c-a13721e08a35@linux.ibm.com \
--to=frankja@linux.ibm.com \
--cc=david@redhat.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=nrb@linux.ibm.com \
--cc=nsg@linux.ibm.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox