Linux s390 Architecture development
 help / color / mirror / Atom feed
From: Nagamani PV <nagamani@linux.ibm.com>
To: Alexandra Winter <wintera@linux.ibm.com>,
	davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
	pabeni@redhat.com
Cc: horms@kernel.org, linux-s390@vger.kernel.org,
	netdev@vger.kernel.org, twinkler@linux.ibm.com,
	heiko.carstens@de.ibm.com, hidayath@linux.ibm.com,
	borntraeger@linux.ibm.com, stable@vger.kernel.org
Subject: Re: [PATCH net-next] net/iucv: fix UAF in afiucv_netdev_event()
Date: Thu, 17 Sep 2026 13:02:16 +0530	[thread overview]
Message-ID: <9ff0027c-6381-455b-97df-7d1081a23e8a@linux.ibm.com> (raw)
In-Reply-To: <8c62f8c9-54ca-4fa2-a199-6d7cf0b26f25@linux.ibm.com>



On 04/08/26 7:00 PM, Alexandra Winter wrote:
> 
> 
> On 04.08.26 14:52, Nagamani PV wrote:
>>> I'd rather continue to work on a more complete fix than take this one,
>>> but both ways are possible.
>>>
>> Understood. This patch addresses the UAF on iucv_sk_list traversal
>> specifically. The lock_sock() concern is at a different level and
>> could be a follow-up.
>>
>> Could you clarify your preference — take this as an incremental fix
>> with a follow-up for lock_sock(), or hold and work toward a combined
>> solution?
> 
> I prefer to work on the combined solution

The combined solution is now posted as [PATCH net v2]:

  https://lore.kernel.org/netdev/20260917071706.23831-1-nagamani@linux.ibm.com/

The v2 fixes all three races in one patch using a two-pass algorithm:
Pass 1 under read_lock_bh() collects matching sockets with sock_hold();
Pass 2 under lock_sock() per socket calls iucv_send_ctrl() and updates
sk_state, serialising against iucv_sock_close() and sock_orphan().

All three bugs confirmed with KASAN + KCSAN TAP on IBM Z.

Thanks,
Nagamani PV

  reply	other threads:[~2026-09-17  7:32 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-03 18:20 [PATCH net-next] net/iucv: fix UAF in afiucv_netdev_event() Nagamani PV
2026-08-04  8:33 ` Alexandra Winter
2026-08-04 12:52   ` Nagamani PV
2026-08-04 13:30     ` Alexandra Winter
2026-09-17  7:32       ` Nagamani PV [this message]
2026-08-04 18:21 ` sashiko-bot
2026-09-17  7:29   ` Nagamani PV
2026-09-17  7:17 ` [PATCH net v2] net/iucv: fix races " Nagamani PV
2026-09-17  7:28   ` sashiko-bot
2026-09-17 14:01   ` Alexandra Winter
2026-09-18  8:58     ` Nagamani PV
2026-09-21  7:36   ` netdev-bot+sashiko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9ff0027c-6381-455b-97df-7d1081a23e8a@linux.ibm.com \
    --to=nagamani@linux.ibm.com \
    --cc=borntraeger@linux.ibm.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=heiko.carstens@de.ibm.com \
    --cc=hidayath@linux.ibm.com \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=stable@vger.kernel.org \
    --cc=twinkler@linux.ibm.com \
    --cc=wintera@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox