From: "Nicholas Piggin" <npiggin@gmail.com>
To: "Claudio Imbrenda" <imbrenda@linux.ibm.com>
Cc: "Thomas Huth" <thuth@redhat.com>, <kvm@vger.kernel.org>,
"Laurent Vivier" <lvivier@redhat.com>,
"Shaoqin Huang" <shahuang@redhat.com>,
"Andrew Jones" <andrew.jones@linux.dev>,
"Nico Boehr" <nrb@linux.ibm.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Alexandru Elisei" <alexandru.elisei@arm.com>,
"Eric Auger" <eric.auger@redhat.com>,
"Janosch Frank" <frankja@linux.ibm.com>,
"David Hildenbrand" <david@redhat.com>,
<linuxppc-dev@lists.ozlabs.org>, <linux-s390@vger.kernel.org>,
<kvmarm@lists.linux.dev>
Subject: Re: [kvm-unit-tests PATCH 1/9] s390x: clean lib/auxinfo.o
Date: Sat, 23 Dec 2023 15:18:45 +1000 [thread overview]
Message-ID: <CXVGJUAN6935.1L9WYI8NQ4R0O@wheely> (raw)
In-Reply-To: <20231222160414.5175ebba@p-imbrenda>
On Sat Dec 23, 2023 at 1:04 AM AEST, Claudio Imbrenda wrote:
> On Fri, 22 Dec 2023 23:50:40 +1000
> Nicholas Piggin <npiggin@gmail.com> wrote:
>
> > Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
> > ---
> > s390x/Makefile | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/s390x/Makefile b/s390x/Makefile
> > index f79fd009..95ef9533 100644
> > --- a/s390x/Makefile
> > +++ b/s390x/Makefile
> > @@ -227,7 +227,7 @@ $(snippet_asmlib): $$(patsubst %.o,%.S,$$@) $(asm-offsets)
> >
> >
> > arch_clean: asm_offsets_clean
> > - $(RM) $(TEST_DIR)/*.{o,elf,bin,lds} $(SNIPPET_DIR)/*/*.{o,elf,*bin,*obj,hdr,lds} $(SNIPPET_DIR)/asm/.*.d $(TEST_DIR)/.*.d lib/s390x/.*.d $(comm-key)
> > + $(RM) $(TEST_DIR)/*.{o,elf,bin,lds} $(SNIPPET_DIR)/*/*.{o,elf,*bin,*obj,hdr,lds} $(SNIPPET_DIR)/asm/.*.d $(TEST_DIR)/.*.d lib/s390x/.*.d lib/auxinfo.o $(comm-key)
>
> it seems other architectures don't need to do the cleanp? what are we
> doing wrong?
x86 does clean it via cflatobjs. arm and powerpc never build the .o
AFAIKS.
Thanks,
Nick
next prev parent reply other threads:[~2023-12-23 5:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-22 13:50 [kvm-unit-tests PATCH 0/9] Multi-migration support Nicholas Piggin
2023-12-22 13:50 ` [kvm-unit-tests PATCH 1/9] s390x: clean lib/auxinfo.o Nicholas Piggin
2023-12-22 15:04 ` Claudio Imbrenda
2023-12-23 5:18 ` Nicholas Piggin [this message]
2023-12-22 13:50 ` [kvm-unit-tests PATCH 2/9] arch-run: Clean up temporary files properly Nicholas Piggin
2023-12-22 13:50 ` [kvm-unit-tests PATCH 3/9] arch-run: Clean up initrd cleanup Nicholas Piggin
2023-12-22 13:50 ` [kvm-unit-tests PATCH 4/9] migration: use a more robust way to wait for background job Nicholas Piggin
2023-12-22 13:50 ` [kvm-unit-tests PATCH 5/9] migration: Support multiple migrations Nicholas Piggin
2023-12-22 13:50 ` [kvm-unit-tests PATCH 6/9] arch-run: rename migration variables Nicholas Piggin
2023-12-22 13:50 ` [kvm-unit-tests PATCH 7/9] migration: Add quiet migration support Nicholas Piggin
2023-12-22 13:50 ` [kvm-unit-tests PATCH 8/9] Add common/ directory for architecture-independent tests Nicholas Piggin
2023-12-22 13:50 ` [kvm-unit-tests PATCH 9/9] migration: add a migration selftest Nicholas Piggin
2023-12-22 15:15 ` Claudio Imbrenda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CXVGJUAN6935.1L9WYI8NQ4R0O@wheely \
--to=npiggin@gmail.com \
--cc=alexandru.elisei@arm.com \
--cc=andrew.jones@linux.dev \
--cc=david@redhat.com \
--cc=eric.auger@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.linux.dev \
--cc=linux-s390@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lvivier@redhat.com \
--cc=nrb@linux.ibm.com \
--cc=pbonzini@redhat.com \
--cc=shahuang@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox