Re: [PATCH v3 3/4] KVM: s390: refactor and split some gmap helpers

["Christoph Schlameuss" <schlameuss@linux.ibm.com>]

On Thu May 22, 2025 at 3:22 PM CEST, Claudio Imbrenda wrote:
> Refactor some gmap functions; move the implementation into a separate
> file with only helper functions. The new helper functions work on vm
> addresses, leaving all gmap logic in the gmap functions, which mostly
> become just wrappers.
>
> The whole gmap handling is going to be moved inside KVM soon, but the
> helper functions need to touch core mm functions, and thus need to
> stay in the core of kernel.
>

Reviewed-by: Christoph Schlameuss <schlameuss@linux.ibm.com>

> Signed-off-by: Claudio Imbrenda <imbrenda@linux.ibm.com>
> ---
>  MAINTAINERS                          |   2 +
>  arch/s390/include/asm/gmap.h         |   2 -
>  arch/s390/include/asm/gmap_helpers.h |  15 ++
>  arch/s390/kvm/diag.c                 |  13 +-
>  arch/s390/kvm/kvm-s390.c             |   5 +-
>  arch/s390/mm/Makefile                |   2 +
>  arch/s390/mm/gmap.c                  | 157 +------------------
>  arch/s390/mm/gmap_helpers.c          | 223 +++++++++++++++++++++++++++
>  8 files changed, 259 insertions(+), 160 deletions(-)
>  create mode 100644 arch/s390/include/asm/gmap_helpers.h
>  create mode 100644 arch/s390/mm/gmap_helpers.c

[...]