public inbox for linux-s390@vger.kernel.org
 help / color / mirror / Atom feed
From: Nathan Chancellor <nathan@kernel.org>
To: Heiko Carstens <hca@linux.ibm.com>
Cc: Vasily Gorbik <gor@linux.ibm.com>,
	Alexander Gordeev <agordeev@linux.ibm.com>,
	Nick Desaulniers <ndesaulniers@google.com>,
	Sven Schnelle <svens@linux.ibm.com>,
	Christian Borntraeger <borntraeger@linux.ibm.com>,
	linux-s390@vger.kernel.org
Subject: Re: [PATCH] scripts/min-tool-version.sh: raise minimum clang version to 15.0.0 for s390
Date: Mon, 31 Oct 2022 08:58:26 -0700	[thread overview]
Message-ID: <Y1/worpj0COQvC5V@dev-arch.thelio-3990X> (raw)
In-Reply-To: <20221031123456.3872220-1-hca@linux.ibm.com>

On Mon, Oct 31, 2022 at 01:34:56PM +0100, Heiko Carstens wrote:
> Before version 14.0.0 llvm's integrated assembler may silently
> generate corrupted code on s390. See e.g. commit e9953b729b78
> ("s390/boot: workaround llvm IAS bug") for further details.
> 
> While there have been workarounds applied for all known existing
> locations, there is nothing that prevents that new code with
> problematic patterns will be added.
> 
> Therefore raise the minimum clang version to 15.0.0. Note that llvm
> commit e547b04d5b2c ("[SystemZ] Bugfix for symbolic displacements."),
> which is included in 15.0.0, fixes the broken code generation.
> 
> Signed-off-by: Heiko Carstens <hca@linux.ibm.com>

Seems like a reasonable thing to bump the minimum supported version
over.

Acked-by: Nathan Chancellor <nathan@kernel.org>

> ---
>  scripts/min-tool-version.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/min-tool-version.sh b/scripts/min-tool-version.sh
> index b6593eac5003..201bccfbc678 100755
> --- a/scripts/min-tool-version.sh
> +++ b/scripts/min-tool-version.sh
> @@ -25,7 +25,7 @@ icc)
>  	;;
>  llvm)
>  	if [ "$SRCARCH" = s390 ]; then
> -		echo 14.0.0
> +		echo 15.0.0
>  	else
>  		echo 11.0.0
>  	fi
> -- 
> 2.34.1
> 

      reply	other threads:[~2022-10-31 15:58 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-31 12:34 [PATCH] scripts/min-tool-version.sh: raise minimum clang version to 15.0.0 for s390 Heiko Carstens
2022-10-31 15:58 ` Nathan Chancellor [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y1/worpj0COQvC5V@dev-arch.thelio-3990X \
    --to=nathan@kernel.org \
    --cc=agordeev@linux.ibm.com \
    --cc=borntraeger@linux.ibm.com \
    --cc=gor@linux.ibm.com \
    --cc=hca@linux.ibm.com \
    --cc=linux-s390@vger.kernel.org \
    --cc=ndesaulniers@google.com \
    --cc=svens@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox