From: Heiko Carstens <hca@linux.ibm.com>
To: Philipp Rudo <prudo@redhat.com>
Cc: linux-s390@vger.kernel.org, egorenar@linux.ibm.com, ltao@redhat.com
Subject: Re: [PATCH] s390/kexec_file: fix error handling when applying relocations
Date: Mon, 6 Dec 2021 19:36:15 +0100 [thread overview]
Message-ID: <Ya5YH2ouT35ehN1e@osiris> (raw)
In-Reply-To: <20211206183337.0aaf7d4c@rhtmp>
> > > r_type = ELF64_R_TYPE(relas[i].r_info);
> > > - arch_kexec_do_relocs(r_type, loc, val, addr);
> > > + ret = arch_kexec_do_relocs(r_type, loc, val, addr);
> > > + if (ret)
> > > + return -EINVAL;
> >
> > I'd prefer if this would return -ENOEXEC, just to be consistent with
> > x86. And _maybe_ it would also make sense to print an error message,
> > including the failing relocation type?
>
> sure, I'll update the return value to -ENOEXEC.
>
> About the error message, I didn't add it on purpose as none of the
> other error cases print one. For consistency I would add one for those
> cases as well. Any objections?
No objections at all. This sounds good!
Thanks,
Heiko
prev parent reply other threads:[~2021-12-06 18:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-06 11:20 [PATCH] s390/kexec_file: fix error handling when applying relocations Philipp Rudo
2021-12-06 17:13 ` Heiko Carstens
2021-12-06 17:33 ` Philipp Rudo
2021-12-06 18:36 ` Heiko Carstens [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ya5YH2ouT35ehN1e@osiris \
--to=hca@linux.ibm.com \
--cc=egorenar@linux.ibm.com \
--cc=linux-s390@vger.kernel.org \
--cc=ltao@redhat.com \
--cc=prudo@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox