From: Tony Lu <tonylu@linux.alibaba.com>
To: Colin Ian King <colin.i.king@gmail.com>
Cc: Karsten Graul <kgraul@linux.ibm.com>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
linux-s390@vger.kernel.org, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net/smc: remove redundant re-assignment of pointer link
Date: Fri, 31 Dec 2021 14:00:39 +0800 [thread overview]
Message-ID: <Yc6ch2hVWwb6coa4@TonyMac-Alibaba> (raw)
In-Reply-To: <20211230153900.274049-1-colin.i.king@gmail.com>
On Thu, Dec 30, 2021 at 03:39:00PM +0000, Colin Ian King wrote:
> The pointer link is being re-assigned the same value that it was
> initialized with in the previous declaration statement. The
> re-assignment is redundant and can be removed.
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
It would be better to add Fixes statement in the end of message.
Fixes: 387707fdf486 ("net/smc: convert static link ID to dynamic references")
And [PATCH net ...] is fine to point out the target. The patch itself
looks good to me, thanks.
Reviewed-by: Tony Lu <tonylu@linux.alibaba.com>
Thanks,
Tony Lu
next prev parent reply other threads:[~2021-12-31 6:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-30 15:39 [PATCH] net/smc: remove redundant re-assignment of pointer link Colin Ian King
2021-12-31 6:00 ` Tony Lu [this message]
2022-01-02 12:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yc6ch2hVWwb6coa4@TonyMac-Alibaba \
--to=tonylu@linux.alibaba.com \
--cc=colin.i.king@gmail.com \
--cc=davem@davemloft.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=kgraul@linux.ibm.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox