From: Tony Lu <tonylu@linux.alibaba.com>
To: "D. Wythe" <alibuda@linux.alibaba.com>
Cc: kgraul@linux.ibm.com, kuba@kernel.org, davem@davemloft.net,
netdev@vger.kernel.org, linux-s390@vger.kernel.org,
linux-rdma@vger.kernel.org
Subject: Re: [PATCH net-next] net/smc: Reduce overflow of smc clcsock listen queue
Date: Tue, 4 Jan 2022 21:01:03 +0800 [thread overview]
Message-ID: <YdRFD8bY897LbUxr@TonyMac-Alibaba> (raw)
In-Reply-To: <1641293930-110897-1-git-send-email-alibuda@linux.alibaba.com>
On Tue, Jan 04, 2022 at 06:58:50PM +0800, D. Wythe wrote:
> From: "D. Wythe" <alibuda@linux.alibaba.com>
>
> In nginx/wrk multithread and 10K connections benchmark, the
> backend TCP connection established very slowly, and lots of TCP
> connections stay in SYN_SENT state.
<snip>
> +struct workqueue_struct *smc_tcp_ls_wq; /* wq for tcp listen work*/
missing a space here ^
> struct workqueue_struct *smc_hs_wq; /* wq for handshake work */
> struct workqueue_struct *smc_close_wq; /* wq for close work */
<snip>
> return (struct smc_sock *)sk;
> }
>
> +extern struct workqueue_struct *smc_tcp_ls_wq; /* wq for tcp listen work*/
missing a space here ^
There are missing two spaces in comments. Besides that, this patch looks
good to me, thanks.
Reviewed-by: Tony Lu <tonylu@linux.alibaba.com>
Thanks.
Tony Lu
next prev parent reply other threads:[~2022-01-04 13:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-04 10:58 [PATCH net-next] net/smc: Reduce overflow of smc clcsock listen queue D. Wythe
2022-01-04 13:01 ` Tony Lu [this message]
2022-01-04 13:04 ` D. Wythe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YdRFD8bY897LbUxr@TonyMac-Alibaba \
--to=tonylu@linux.alibaba.com \
--cc=alibuda@linux.alibaba.com \
--cc=davem@davemloft.net \
--cc=kgraul@linux.ibm.com \
--cc=kuba@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox