From: Heiko Carstens <hca@linux.ibm.com>
To: Yu Liao <liaoyu15@huawei.com>
Cc: gor@linux.ibm.com, agordeev@linux.ibm.com,
linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org,
liwei391@huawei.com
Subject: Re: [PATCH] s390: cleanup timer API use
Date: Thu, 24 Mar 2022 18:34:01 +0100 [thread overview]
Message-ID: <YjyriSRJY1mw04Jt@osiris> (raw)
In-Reply-To: <20220322030057.1243196-1-liaoyu15@huawei.com>
On Tue, Mar 22, 2022 at 11:00:57AM +0800, Yu Liao wrote:
> cleanup the s390's use of the timer API
> - del_timer() contains timer_pending() condition
> - mod_timer(timer, expires) is equivalent to:
>
> del_timer(timer);
> timer->expires = expires;
> add_timer(timer);
>
> If the timer is inactive it will be activated, using add_timer() on
> condition !timer_pending(&private->timer) is redundant.
>
> Just cleanup, no logic change.
>
> Signed-off-by: Yu Liao <liaoyu15@huawei.com>
> ---
> drivers/s390/char/sclp.c | 4 +---
> drivers/s390/char/sclp_con.c | 3 +--
> drivers/s390/char/sclp_vt220.c | 6 ++----
> drivers/s390/cio/device_fsm.c | 12 +++---------
> drivers/s390/cio/eadm_sch.c | 12 +++---------
> 5 files changed, 10 insertions(+), 27 deletions(-)
Applied, thanks.
prev parent reply other threads:[~2022-03-24 17:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-22 3:00 [PATCH] s390: cleanup timer API use Yu Liao
2022-03-24 17:34 ` Heiko Carstens [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YjyriSRJY1mw04Jt@osiris \
--to=hca@linux.ibm.com \
--cc=agordeev@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=liaoyu15@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=liwei391@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox