From: Jason Gunthorpe <jgg@nvidia.com>
To: "Liu, Yi L" <yi.l.liu@intel.com>
Cc: "alex.williamson@redhat.com" <alex.williamson@redhat.com>,
"Tian, Kevin" <kevin.tian@intel.com>,
"joro@8bytes.org" <joro@8bytes.org>,
"robin.murphy@arm.com" <robin.murphy@arm.com>,
"cohuck@redhat.com" <cohuck@redhat.com>,
"eric.auger@redhat.com" <eric.auger@redhat.com>,
"nicolinc@nvidia.com" <nicolinc@nvidia.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"mjrosato@linux.ibm.com" <mjrosato@linux.ibm.com>,
"chao.p.peng@linux.intel.com" <chao.p.peng@linux.intel.com>,
"yi.y.sun@linux.intel.com" <yi.y.sun@linux.intel.com>,
"peterx@redhat.com" <peterx@redhat.com>,
"jasowang@redhat.com" <jasowang@redhat.com>,
"shameerali.kolothum.thodi@huawei.com"
<shameerali.kolothum.thodi@huawei.com>,
"lulu@redhat.com" <lulu@redhat.com>,
"suravee.suthikulpanit@amd.com" <suravee.suthikulpanit@amd.com>,
"intel-gvt-dev@lists.freedesktop.org"
<intel-gvt-dev@lists.freedesktop.org>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>,
"linux-s390@vger.kernel.org" <linux-s390@vger.kernel.org>,
"Hao, Xudong" <xudong.hao@intel.com>,
"Zhao, Yan Y" <yan.y.zhao@intel.com>,
"Xu, Terrence" <terrence.xu@intel.com>,
"Jiang, Yanting" <yanting.jiang@intel.com>,
"Duan, Zhenzhong" <zhenzhong.duan@intel.com>,
"clegoate@redhat.com" <clegoate@redhat.com>
Subject: Re: [PATCH v13 21/22] vfio: Compile vfio_group infrastructure optionally
Date: Mon, 17 Jul 2023 09:33:56 -0300 [thread overview]
Message-ID: <ZLU1NKfKQkIPUIxw@nvidia.com> (raw)
In-Reply-To: <DS0PR11MB7529C571419F1DB629AB7E92C33BA@DS0PR11MB7529.namprd11.prod.outlook.com>
On Mon, Jul 17, 2023 at 06:36:19AM +0000, Liu, Yi L wrote:
> Hi Alex, Jason,
>
> I found a minor nit on the kconfig. The below configuration is valid.
> But user cannot use vfio directly as there is no /dev/vfio/vfio. Although
> user can open /dev/iommu instead. This is not good.
>
> CONFIG_IOMMUFD=y
> CONFIG_VFIO_DEVICE_CDEv=n
> CONFIG_VFIO_GROUP=y
> CONFIG_VFIO_CONTAINER=n
> CONFIG_IOMMUFD_VFIO_CONTAINER=n
>
> So need to have the below change. I'll incorporate this change in
> this series after your ack.
This is fine, we decided to allow this in the original vfio series. It
is usable in that you have to use iommufd natively with the group
interface. It won't be backwards compatible with current userspace.
Jason
next prev parent reply other threads:[~2023-07-17 12:34 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-16 9:39 [PATCH v13 00/22] Add vfio_device cdev for iommufd support Yi Liu
2023-06-16 9:39 ` [PATCH v13 01/22] vfio: Allocate per device file structure Yi Liu
2023-06-16 9:39 ` [PATCH v13 02/22] vfio: Refine vfio file kAPIs for KVM Yi Liu
2023-06-16 9:39 ` [PATCH v13 03/22] vfio: Accept vfio device file in the KVM facing kAPI Yi Liu
2023-06-16 9:39 ` [PATCH v13 04/22] kvm/vfio: Prepare for accepting vfio device fd Yi Liu
2023-06-16 9:39 ` [PATCH v13 05/22] kvm/vfio: Accept vfio device file from userspace Yi Liu
2023-06-16 9:39 ` [PATCH v13 06/22] vfio: Pass struct vfio_device_file * to vfio_device_open/close() Yi Liu
2023-06-16 9:39 ` [PATCH v13 07/22] vfio: Block device access via device fd until device is opened Yi Liu
2023-06-16 9:39 ` [PATCH v13 08/22] vfio: Add cdev_device_open_cnt to vfio_group Yi Liu
2023-06-16 9:39 ` [PATCH v13 09/22] vfio: Make vfio_df_open() single open for device cdev path Yi Liu
2023-06-16 9:39 ` [PATCH v13 10/22] vfio-iommufd: Move noiommu compat validation out of vfio_iommufd_bind() Yi Liu
2023-06-16 9:39 ` [PATCH v13 11/22] vfio-iommufd: Split bind/attach into two steps Yi Liu
2023-06-16 9:39 ` [PATCH v13 12/22] vfio: Record devid in vfio_device_file Yi Liu
2023-06-16 9:39 ` [PATCH v13 13/22] vfio-iommufd: Add detach_ioas support for physical VFIO devices Yi Liu
2023-06-16 9:39 ` [PATCH v13 14/22] iommufd/device: Add iommufd_access_detach() API Yi Liu
2023-06-16 9:39 ` [PATCH v13 15/22] vfio-iommufd: Add detach_ioas support for emulated VFIO devices Yi Liu
2023-06-16 9:39 ` [PATCH v13 16/22] vfio: Move vfio_device_group_unregister() to be the first operation in unregister Yi Liu
2023-06-16 9:39 ` [PATCH v13 17/22] vfio: Add cdev for vfio_device Yi Liu
2023-06-16 9:39 ` [PATCH v13 18/22] vfio: Add VFIO_DEVICE_BIND_IOMMUFD Yi Liu
2023-06-16 9:39 ` [PATCH v13 19/22] vfio: Add VFIO_DEVICE_[AT|DE]TACH_IOMMUFD_PT Yi Liu
2023-06-16 9:39 ` [PATCH v13 20/22] vfio: Move the IOMMU_CAP_CACHE_COHERENCY check in __vfio_register_dev() Yi Liu
2023-06-16 9:39 ` [PATCH v13 21/22] vfio: Compile vfio_group infrastructure optionally Yi Liu
2023-07-17 6:36 ` Liu, Yi L
2023-07-17 8:08 ` Liu, Yi L
2023-07-17 18:45 ` Alex Williamson
2023-07-18 1:18 ` Liu, Yi L
2023-07-17 12:33 ` Jason Gunthorpe [this message]
2023-07-17 12:50 ` Liu, Yi L
2023-06-16 9:39 ` [PATCH v13 22/22] docs: vfio: Add vfio device cdev description Yi Liu
2023-06-21 21:54 ` Alex Williamson
2023-06-27 8:54 ` Liu, Yi L
2023-06-27 16:12 ` Jason Gunthorpe
2023-06-28 0:56 ` Liu, Yi L
2023-06-28 12:33 ` Jason Gunthorpe
[not found] ` <20230627113430.129811ef.alex.williamson@redhat.com>
2023-06-28 1:10 ` Liu, Yi L
2023-06-28 12:34 ` Jason Gunthorpe
2023-06-21 9:17 ` [PATCH v13 00/22] Add vfio_device cdev for iommufd support Duan, Zhenzhong
2023-06-23 16:48 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZLU1NKfKQkIPUIxw@nvidia.com \
--to=jgg@nvidia.com \
--cc=alex.williamson@redhat.com \
--cc=chao.p.peng@linux.intel.com \
--cc=clegoate@redhat.com \
--cc=cohuck@redhat.com \
--cc=eric.auger@redhat.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-gvt-dev@lists.freedesktop.org \
--cc=jasowang@redhat.com \
--cc=joro@8bytes.org \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=lulu@redhat.com \
--cc=mjrosato@linux.ibm.com \
--cc=nicolinc@nvidia.com \
--cc=peterx@redhat.com \
--cc=robin.murphy@arm.com \
--cc=shameerali.kolothum.thodi@huawei.com \
--cc=suravee.suthikulpanit@amd.com \
--cc=terrence.xu@intel.com \
--cc=xudong.hao@intel.com \
--cc=yan.y.zhao@intel.com \
--cc=yanting.jiang@intel.com \
--cc=yi.l.liu@intel.com \
--cc=yi.y.sun@linux.intel.com \
--cc=zhenzhong.duan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox