From: Adrian Reber <areber@redhat.com>
To: Heiko Carstens <hca@linux.ibm.com>
Cc: Alexander Gordeev <agordeev@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
linux-s390@vger.kernel.org
Subject: Re: [PATCH] s390/ptrace: add missing linux/const.h include
Date: Tue, 1 Aug 2023 16:11:39 +0200 [thread overview]
Message-ID: <ZMkSm+CWmAJ9EOY5@dcbz.redhat.com> (raw)
In-Reply-To: <20230731183926.330932-1-hca@linux.ibm.com>
On Mon, Jul 31, 2023 at 08:39:26PM +0200, Heiko Carstens wrote:
> Adrian Reber reported the following CRIU build bug after
> commit b8af5999779d ("s390/ptrace: make all psw related
> defines also available for asm"):
>
> compel/arch/s390/src/lib/infect.c: In function 'arch_can_dump_task':
> compel/arch/s390/src/lib/infect.c:523:25: error: 'UL' undeclared (first use in this function)
> 523 | if (psw->mask & PSW_MASK_RI) {
> | ^~~~~~~~~~~
>
> Add the missing linux/const.h include to fix this.
Thanks. That fixes the build failure for me.
Adrian
> Reported-by: Adrian Reber <areber@redhat.com>
> Closes: https://bugzilla.redhat.com/show_bug.cgi?id=2225745
> Link: https://github.com/checkpoint-restore/criu/pull/2232
> Fixes: b8af5999779d ("s390/ptrace: make all psw related defines also available for asm")
> Signed-off-by: Heiko Carstens <hca@linux.ibm.com>
> ---
> arch/s390/include/uapi/asm/ptrace.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/s390/include/uapi/asm/ptrace.h b/arch/s390/include/uapi/asm/ptrace.h
> index f0fe3bcc78a8..bb0826024bb9 100644
> --- a/arch/s390/include/uapi/asm/ptrace.h
> +++ b/arch/s390/include/uapi/asm/ptrace.h
> @@ -8,6 +8,8 @@
> #ifndef _UAPI_S390_PTRACE_H
> #define _UAPI_S390_PTRACE_H
>
> +#include <linux/const.h>
> +
> /*
> * Offsets in the user_regs_struct. They are used for the ptrace
> * system call and in entry.S
> --
> 2.39.2
>
next prev parent reply other threads:[~2023-08-01 14:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-31 18:39 [PATCH] s390/ptrace: add missing linux/const.h include Heiko Carstens
2023-08-01 14:11 ` Adrian Reber [this message]
2023-08-01 14:42 ` Heiko Carstens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZMkSm+CWmAJ9EOY5@dcbz.redhat.com \
--to=areber@redhat.com \
--cc=agordeev@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=linux-s390@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox