From: Alexander Gordeev <agordeev@linux.ibm.com>
To: Joe Lawrence <joe.lawrence@redhat.com>
Cc: Josh Poimboeuf <jpoimboe@kernel.org>,
Jiri Kosina <jikos@kernel.org>, Miroslav Benes <mbenes@suse.cz>,
Petr Mladek <pmladek@suse.com>,
linux-kselftest@vger.kernel.org, live-patching@vger.kernel.org,
linux-s390@vger.kernel.org
Subject: Re: selftests/livepatch fails on s390
Date: Tue, 19 Dec 2023 16:23:45 +0100 [thread overview]
Message-ID: <ZYG1gXy3IodeOWuX@tuxmaker.boeblingen.de.ibm.com> (raw)
In-Reply-To: <8adb8209-d49b-4feb-5ab3-47ca4f3cefbc@redhat.com>
On Tue, Dec 19, 2023 at 09:50:18AM -0500, Joe Lawrence wrote:
> There is a loop_util() utility function in the script that could be used
> to wait, like:
>
> log "$last_dmesg_msg"
> loop_until "dmesg | grep -q '$last_dmesg_msg'" ||
> die "Can't find canary dmesg entry, buffer overrun?"
> LAST_DMESG=$(dmesg | grep "$last_dmesg_msg")
>
> That should catch 1) short latencies and 2) buffer rollover. Maybe that
> is good enough?
I guess, if loop_until() would fail in case a message did not show up
in meaningful time, that would be it.
> --
> Joe
>
next prev parent reply other threads:[~2023-12-19 15:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-18 10:44 selftests/livepatch fails on s390 Alexander Gordeev
2023-12-18 16:44 ` Joe Lawrence
2023-12-18 22:44 ` Joe Lawrence
2023-12-19 9:45 ` Alexander Gordeev
2023-12-19 14:50 ` Joe Lawrence
2023-12-19 15:23 ` Alexander Gordeev [this message]
2023-12-20 13:19 ` Petr Mladek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZYG1gXy3IodeOWuX@tuxmaker.boeblingen.de.ibm.com \
--to=agordeev@linux.ibm.com \
--cc=jikos@kernel.org \
--cc=joe.lawrence@redhat.com \
--cc=jpoimboe@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=mbenes@suse.cz \
--cc=pmladek@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox