From: Thomas Huth <thuth@redhat.com>
To: Nico Boehr <nrb@linux.ibm.com>,
Pierre Morel <pmorel@linux.ibm.com>,
linux-s390@vger.kernel.org
Cc: frankja@linux.ibm.com, kvm@vger.kernel.org,
imbrenda@linux.ibm.com, david@redhat.com, nsg@linux.ibm.com
Subject: Re: [kvm-unit-tests PATCH v10 1/2] s390x: topology: Check the Perform Topology Function
Date: Mon, 3 Jul 2023 10:42:43 +0200 [thread overview]
Message-ID: <a162644d-f548-7c34-e501-d8080d1d0bef@redhat.com> (raw)
In-Reply-To: <168802854091.40048.12063023827984391132@t14-nrb>
On 29/06/2023 10.49, Nico Boehr wrote:
> Quoting Pierre Morel (2023-06-27 10:21:54)
> [...]
>> diff --git a/s390x/topology.c b/s390x/topology.c
>> new file mode 100644
>> index 0000000..7e1bbf9
>> --- /dev/null
>> +++ b/s390x/topology.c
>> @@ -0,0 +1,190 @@
> [...]
>> +static void check_privilege(int fc)
>> +{
>> + unsigned long rc;
>> + char buf[20];
>> +
>> + snprintf(buf, sizeof(buf), "Privileged fc %d", fc);
>> + report_prefix_push(buf);
>
> We have report_prefix_pushf (note the f at the end!) for this.
>
> I can fix that up when picking in case there's no new version, though.
With that fixed:
Reviewed-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2023-07-03 8:43 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-27 8:21 [kvm-unit-tests PATCH v10 0/2] S390x: CPU Topology Information Pierre Morel
2023-06-27 8:21 ` [kvm-unit-tests PATCH v10 1/2] s390x: topology: Check the Perform Topology Function Pierre Morel
2023-06-29 8:49 ` Nico Boehr
2023-06-29 12:53 ` Pierre Morel
2023-07-03 8:42 ` Thomas Huth [this message]
2023-07-12 9:09 ` Pierre Morel
2023-07-12 9:10 ` Pierre Morel
2023-06-27 8:21 ` [kvm-unit-tests PATCH v10 2/2] s390x: topology: Checking Configuration Topology Information Pierre Morel
2023-06-29 8:47 ` Nico Boehr
2023-07-06 10:48 ` Thomas Huth
2023-07-10 8:36 ` Nico Boehr
2023-07-10 14:38 ` Thomas Huth
2023-07-11 8:07 ` Nico Boehr
2023-07-11 8:43 ` Thomas Huth
2023-07-12 9:08 ` Pierre Morel
2023-06-30 12:29 ` [kvm-unit-tests PATCH v10 0/2] S390x: CPU " Nico Boehr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a162644d-f548-7c34-e501-d8080d1d0bef@redhat.com \
--to=thuth@redhat.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=nrb@linux.ibm.com \
--cc=nsg@linux.ibm.com \
--cc=pmorel@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox