From: Thomas Huth <thuth@redhat.com>
To: Janosch Frank <frankja@linux.ibm.com>, kvm@vger.kernel.org
Cc: borntraeger@de.ibm.com, linux-s390@vger.kernel.org,
david@redhat.com, cohuck@redhat.com
Subject: Re: [kvm-unit-tests PATCH v5 3/7] s390x: Stop the cpu that is executing exit()
Date: Sat, 1 Feb 2020 19:55:38 +0100 [thread overview]
Message-ID: <a2c462d4-c27c-2da5-b168-016a063d17c7@redhat.com> (raw)
In-Reply-To: <20200201152851.82867-4-frankja@linux.ibm.com>
On 01/02/2020 16.28, Janosch Frank wrote:
> CPU 0 is not necessarily the CPU which does the exit if we ran into a
> test abort situation. So, let's ask stap() which cpu does the exit and
> stop it on exit.
>
> Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
> ---
> lib/s390x/io.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/s390x/io.c b/lib/s390x/io.c
> index 32f09b5..e091c37 100644
> --- a/lib/s390x/io.c
> +++ b/lib/s390x/io.c
> @@ -46,6 +46,6 @@ void exit(int code)
> smp_teardown();
> printf("\nEXIT: STATUS=%d\n", ((code) << 1) | 1);
> while (1) {
> - sigp(0, SIGP_STOP, 0, NULL);
> + sigp(stap(), SIGP_STOP, 0, NULL);
> }
> }
Right, smp_teardown stops already all CPUs except for the current one,
so this is the last one running here.
Reviewed-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2020-02-01 18:55 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-01 15:28 [kvm-unit-tests PATCH v5 0/7] s390x: smp: Improve smp code and reset checks Janosch Frank
2020-02-01 15:28 ` [kvm-unit-tests PATCH v5 1/7] s390x: smp: Cleanup smp.c Janosch Frank
2020-02-03 11:04 ` Cornelia Huck
2020-02-01 15:28 ` [kvm-unit-tests PATCH v5 2/7] s390x: smp: Fix ecall and emcall report strings Janosch Frank
2020-02-01 18:53 ` Thomas Huth
2020-02-03 11:06 ` Cornelia Huck
2020-02-01 15:28 ` [kvm-unit-tests PATCH v5 3/7] s390x: Stop the cpu that is executing exit() Janosch Frank
2020-02-01 18:55 ` Thomas Huth [this message]
2020-02-03 11:19 ` Cornelia Huck
2020-02-01 15:28 ` [kvm-unit-tests PATCH v5 4/7] s390x: Add cpu id to interrupt error prints Janosch Frank
2020-02-01 18:57 ` Thomas Huth
2020-02-01 15:28 ` [kvm-unit-tests PATCH v5 5/7] s390x: smp: Only use smp_cpu_setup once Janosch Frank
2020-02-01 15:28 ` [kvm-unit-tests PATCH v5 6/7] s390x: smp: Rework cpu start and active tracking Janosch Frank
2020-02-01 19:03 ` Thomas Huth
2020-02-01 15:28 ` [kvm-unit-tests PATCH v5 7/7] s390x: smp: Wait for cpu setup to finish Janosch Frank
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a2c462d4-c27c-2da5-b168-016a063d17c7@redhat.com \
--to=thuth@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox