From: Thomas Huth <thuth@redhat.com>
To: Janosch Frank <frankja@linux.ibm.com>, kvm@vger.kernel.org
Cc: linux-s390@vger.kernel.org, imbrenda@linux.ibm.com,
david@redhat.com, cohuck@redhat.com
Subject: Re: [kvm-unit-tests PATCH v2 1/3] s390x: snippets: Add gitignore as well as linker script and start assembly
Date: Sun, 4 Jul 2021 18:42:31 +0200 [thread overview]
Message-ID: <a433cb96-88af-663d-50b9-44b96db23d25@redhat.com> (raw)
In-Reply-To: <20210629131841.17319-2-frankja@linux.ibm.com>
On 29/06/2021 15.18, Janosch Frank wrote:
> Snippets are small guests That can be run under a unit test as the
> hypervisor.
s/That/that/. Maybe also rather something like:
Snippets are small guests which can be run under a unit test that implements
a simple hypervisor.
?
> They can be written in C or assembly. The C code needs a
> linker script and a start assembly file that jumps to main to work
> properly. So let's add that as well as a gitignore entry for the new
> files.
Rest of the file looks fine to me.
Reviewed-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2021-07-04 16:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-29 13:18 [kvm-unit-tests PATCH v2 0/3] s390x: Add snippet support Janosch Frank
2021-06-29 13:18 ` [kvm-unit-tests PATCH v2 1/3] s390x: snippets: Add gitignore as well as linker script and start assembly Janosch Frank
2021-07-04 16:42 ` Thomas Huth [this message]
2021-06-29 13:18 ` [kvm-unit-tests PATCH v2 2/3] s390x: snippets: Add snippet compilation Janosch Frank
2021-06-29 13:18 ` [kvm-unit-tests PATCH v2 3/3] s390x: mvpg: Add SIE mvpg test Janosch Frank
2021-07-05 7:24 ` Thomas Huth
2021-07-05 9:37 ` Janosch Frank
2021-07-05 9:52 ` Thomas Huth
2021-07-05 9:56 ` Janosch Frank
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a433cb96-88af-663d-50b9-44b96db23d25@redhat.com \
--to=thuth@redhat.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox