From: Joe Perches <joe@perches.com>
To: Alexandra Winter <wintera@linux.ibm.com>,
Jiang Jian <jiangjian@cdjrlc.com>
Cc: wenjia@linux.ibm.com, hca@linux.ibm.com, gor@linux.ibm.com,
agordeev@linux.ibm.com, borntraeger@linux.ibm.com,
svens@linux.ibm.com, linux-s390@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: s390: drop unexpected word "the" in the comments
Date: Tue, 21 Jun 2022 08:01:17 -0700 [thread overview]
Message-ID: <a502003f9ba31c660ddb9c9d8683b7b2a01d12f7.camel@perches.com> (raw)
In-Reply-To: <09b411b2-0e1f-26d5-c0ea-8ee6504bdcfd@linux.ibm.com>
On Tue, 2022-06-21 at 13:58 +0200, Alexandra Winter wrote:
> On 21.06.22 13:37, Jiang Jian wrote:
> > there is an unexpected word "the" in the comments that need to be dropped
[]
> > * have to request a PCI to be sure the the PCI
> > * have to request a PCI to be sure the PCI
[]
> > diff --git a/drivers/s390/net/qeth_core_main.c b/drivers/s390/net/qeth_core_main.c
[]
> > @@ -3565,7 +3565,7 @@ static void qeth_flush_buffers(struct qeth_qdio_out_q *queue, int index,
> > if (!atomic_read(&queue->set_pci_flags_count)) {
> > /*
> > * there's no outstanding PCI any more, so we
> > - * have to request a PCI to be sure the the PCI
Might have intended "that the" and not "the the"
> > + * have to request a PCI to be sure the PCI
> > * will wake at some time in the future then we
> > * can flush packed buffers that might still be
> > * hanging around, which can happen if no
And this is a relatively long sentence.
Perhaps something like:
if (!atomic_read(&queue->set_pci_flags_count)) {
/*
* there's no outstanding PCI any more so:
* o request a PCI to be sure that the PCI
* will wake at some time in the future
* o flush packed buffers that might still be
* hanging around (which can happen if no
* further send was requested by the stack)
*/
next prev parent reply other threads:[~2022-06-21 15:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-21 11:37 [PATCH] net: s390: drop unexpected word "the" in the comments Jiang Jian
2022-06-21 11:58 ` Alexandra Winter
2022-06-21 15:01 ` Joe Perches [this message]
[not found] ` <tencent_05711A707693017879EC87F7@qq.com>
2022-06-21 15:30 ` Joe Perches
2022-06-21 15:44 ` Alexandra Winter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a502003f9ba31c660ddb9c9d8683b7b2a01d12f7.camel@perches.com \
--to=joe@perches.com \
--cc=agordeev@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=jiangjian@cdjrlc.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=svens@linux.ibm.com \
--cc=wenjia@linux.ibm.com \
--cc=wintera@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox