From: Janosch Frank <frankja@linux.ibm.com>
To: Claudio Imbrenda <imbrenda@linux.ibm.com>, kvm@vger.kernel.org
Cc: linux-s390@vger.kernel.org, scgl@linux.ibm.com,
borntraeger@de.ibm.com, pmorel@linux.ibm.com,
pasic@linux.ibm.com, nrb@linux.ibm.com, thuth@redhat.com,
david@redhat.com
Subject: Re: [kvm-unit-tests PATCH v1 1/4] s390x: remove spurious includes
Date: Thu, 31 Mar 2022 17:04:34 +0200 [thread overview]
Message-ID: <a90856c8-875b-a2a9-a97d-c7cfeba5afd0@linux.ibm.com> (raw)
In-Reply-To: <20220330144339.261419-2-imbrenda@linux.ibm.com>
On 3/30/22 16:43, Claudio Imbrenda wrote:
> Remove unused includes of vm.h
Reviewed-by: Janosch Frank <frankja@linux.ibm.com>
>
> Signed-off-by: Claudio Imbrenda <imbrenda@linux.ibm.com>
> ---
> s390x/mvpg-sie.c | 1 -
> s390x/pv-diags.c | 1 -
I think there are more unused includes in pv-diags.c. I need to take
another look at that.
> s390x/spec_ex-sie.c | 1 -
> 3 files changed, 3 deletions(-)
>
> diff --git a/s390x/mvpg-sie.c b/s390x/mvpg-sie.c
> index 8ae9a52a..46a2edb6 100644
> --- a/s390x/mvpg-sie.c
> +++ b/s390x/mvpg-sie.c
> @@ -16,7 +16,6 @@
> #include <asm/facility.h>
> #include <asm/mem.h>
> #include <alloc_page.h>
> -#include <vm.h>
> #include <sclp.h>
> #include <sie.h>
> #include <snippet.h>
> diff --git a/s390x/pv-diags.c b/s390x/pv-diags.c
> index 110547ad..6899b859 100644
> --- a/s390x/pv-diags.c
> +++ b/s390x/pv-diags.c
> @@ -19,7 +19,6 @@
> #include <asm/sigp.h>
> #include <smp.h>
> #include <alloc_page.h>
> -#include <vm.h>
> #include <vmalloc.h>
> #include <sclp.h>
> #include <snippet.h>
> diff --git a/s390x/spec_ex-sie.c b/s390x/spec_ex-sie.c
> index 5dea4115..d8e25e75 100644
> --- a/s390x/spec_ex-sie.c
> +++ b/s390x/spec_ex-sie.c
> @@ -11,7 +11,6 @@
> #include <asm/page.h>
> #include <asm/arch_def.h>
> #include <alloc_page.h>
> -#include <vm.h>
> #include <sie.h>
> #include <snippet.h>
>
next prev parent reply other threads:[~2022-03-31 15:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-30 14:43 [kvm-unit-tests PATCH v1 0/4] lib: s390x: Refactor and rename vm.[ch] Claudio Imbrenda
2022-03-30 14:43 ` [kvm-unit-tests PATCH v1 1/4] s390x: remove spurious includes Claudio Imbrenda
2022-03-31 15:04 ` Janosch Frank [this message]
2022-03-30 14:43 ` [kvm-unit-tests PATCH v1 2/4] lib: s390: rename and refactor vm.[ch] Claudio Imbrenda
2022-03-31 15:15 ` Janosch Frank
2022-03-30 14:43 ` [kvm-unit-tests PATCH v1 3/4] lib: s390x: functions for machine models Claudio Imbrenda
2022-03-31 15:21 ` Janosch Frank
2022-03-30 14:43 ` [kvm-unit-tests PATCH v1 4/4] lib: s390x: stidp wrapper and move get_machine_id Claudio Imbrenda
2022-03-31 15:24 ` Janosch Frank
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a90856c8-875b-a2a9-a97d-c7cfeba5afd0@linux.ibm.com \
--to=frankja@linux.ibm.com \
--cc=borntraeger@de.ibm.com \
--cc=david@redhat.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=nrb@linux.ibm.com \
--cc=pasic@linux.ibm.com \
--cc=pmorel@linux.ibm.com \
--cc=scgl@linux.ibm.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox