From: "Arnd Bergmann" <arnd@arndb.de>
To: "Heiko Carstens" <hca@linux.ibm.com>, "Thomas Huth" <thuth@redhat.com>
Cc: "Vasily Gorbik" <gor@linux.ibm.com>,
"Alexander Gordeev" <agordeev@linux.ibm.com>,
linux-s390@vger.kernel.org,
"Christian Borntraeger" <borntraeger@linux.ibm.com>,
"Sven Schnelle" <svens@linux.ibm.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] s390/uapi: Replace __ASSEMBLY__ with __ASSEMBLER__ in uapi headers
Date: Mon, 10 Mar 2025 12:07:40 +0100 [thread overview]
Message-ID: <ab1ab15a-89e1-4c26-b7a2-6147a10a2fca@app.fastmail.com> (raw)
In-Reply-To: <20250310104910.27210B18-hca@linux.ibm.com>
On Mon, Mar 10, 2025, at 11:49, Heiko Carstens wrote:
> On Mon, Mar 10, 2025 at 11:26:57AM +0100, Thomas Huth wrote:
>
> Did this cause any sorts of problems? I can see this pattern all over
> the place, so why is this now a problem?
>
> Also, wouldn't it be better to fix this with an sed statement in
> scripts/headers_install.sh instead? Otherwise this is going to be a
> never ending story since those things will be re-introduced all the
> time.
It should certainly be done in a consistent way across all
architectures and architecture-independent headers. I see that
all uapi headers use __ASSEMBLY__ consistently, while a few non-uapi
headers use __ASSEMBLER__.
glibc obviously defines __ASSEMBLY__ whenever it includes one
of the kernel headers that need this from a .S file. Unless
there is a known problem with the current code, leaving this
unchanged is probably the least risky way.
Arnd
next prev parent reply other threads:[~2025-03-10 11:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-10 10:26 [PATCH] s390/uapi: Replace __ASSEMBLY__ with __ASSEMBLER__ in uapi headers Thomas Huth
2025-03-10 10:49 ` Heiko Carstens
2025-03-10 11:07 ` Arnd Bergmann [this message]
2025-03-10 12:14 ` Thomas Huth
2025-03-10 12:50 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ab1ab15a-89e1-4c26-b7a2-6147a10a2fca@app.fastmail.com \
--to=arnd@arndb.de \
--cc=agordeev@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=svens@linux.ibm.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox