Re: [PATCH 1/2] s390/kvm: Refactor __diag_time_slice_end_directed for single exit point

[Christian Borntraeger <borntraeger@linux.ibm.com>]

Am 19.06.26 um 15:49 schrieb Heiko Carstens:
> On Fri, Jun 19, 2026 at 12:27:56PM +0200, Christian Borntraeger wrote:
>>> +	const char *result;
> ...
>>> +	result = "ignored";
>>> +out:
>>> +	VCPU_EVENT(vcpu, 5, "diag time slice end directed to %d: %s", tid,
>>> +		   result);
>>
>> result is a local variable that will go out of scope. You can not reference those
>> in the s390dbf feature as it will only store the string pointer and it will not
>> resolve the %s. So this wont work.
> 
> Why should this not work? The life time of result doesn't matter. The
> _content_ of 'result', which is a pointer to ro.data section, where
> the strings reside, is passed to the debug feature call. 'result' is
> not required to resolve "%s" later.
> 
> But maybe I miss your point?

No you are right. The string "ignored" and co are indeed not on the stack so
this will work.