From: Janosch Frank <frankja@linux.ibm.com>
To: Marc Hartmayer <mhartmay@linux.ibm.com>,
linux-s390@vger.kernel.org, Thomas Huth <thuth@redhat.com>
Cc: kvm@vger.kernel.org, Nico Boehr <nrb@linux.ibm.com>
Subject: Re: [kvm-unit-tests PATCH] s390x: Support newer version of genprotimg
Date: Mon, 9 Dec 2024 11:05:20 +0100 [thread overview]
Message-ID: <ae33b52a-35d6-4323-862e-50ab79635080@linux.ibm.com> (raw)
In-Reply-To: <20241205160011.100609-1-mhartmay@linux.ibm.com>
On 12/5/24 5:00 PM, Marc Hartmayer wrote:
> Since s390-tools commit f4cf4ae6ebb1 ("rust: Add a new tool called 'pvimg'") the
> genprotimg command checks if a given image/kernel is a s390x Linux kernel, and
> it does no longer overwrite the output file by default. Disable the component
> check, since a KUT test is being prepared, and use the '--overwrite' option to
> overwrite the output.
>
> Signed-off-by: Marc Hartmayer <mhartmay@linux.ibm.com>
I'm okish with this since there will be no changes for users that
convert linux kernels AFAIK. So we're the odd one out anyway.
Just be prepared that I might not be as lenient next time. This is the
second time that we have to introduce conditional arguments and the make
file only gets messier every time.
prev parent reply other threads:[~2024-12-09 10:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-05 16:00 [kvm-unit-tests PATCH] s390x: Support newer version of genprotimg Marc Hartmayer
2024-12-09 7:42 ` Nico Boehr
2024-12-09 7:59 ` Nico Boehr
2024-12-09 9:34 ` Marc Hartmayer
2024-12-09 9:46 ` Nico Boehr
2024-12-09 10:05 ` Janosch Frank [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ae33b52a-35d6-4323-862e-50ab79635080@linux.ibm.com \
--to=frankja@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=mhartmay@linux.ibm.com \
--cc=nrb@linux.ibm.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox