From: Karsten Graul <kgraul@linux.ibm.com>
To: Tony Lu <tonylu@linux.alibaba.com>,
davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com
Cc: netdev@vger.kernel.org, linux-s390@vger.kernel.org
Subject: Re: [PATCH net] net/smc: Fix sock leak when release after smc_shutdown()
Date: Thu, 14 Apr 2022 10:29:19 +0200 [thread overview]
Message-ID: <aee77dea-7161-e988-27f8-bbf6c28d048a@linux.ibm.com> (raw)
In-Reply-To: <20220414075102.84366-1-tonylu@linux.alibaba.com>
On 14/04/2022 09:51, Tony Lu wrote:
> Since commit e5d5aadcf3cd ("net/smc: fix sk_refcnt underflow on linkdown
> and fallback"), for a fallback connection, __smc_release() does not call
> sock_put() if its state is already SMC_CLOSED.
>
> When calling smc_shutdown() after falling back, its state is set to
> SMC_CLOSED but does not call sock_put(), so this patch calls it.
>
> Reported-and-tested-by: syzbot+6e29a053eb165bd50de5@syzkaller.appspotmail.com
> Fixes: e5d5aadcf3cd ("net/smc: fix sk_refcnt underflow on linkdown and fallback")
> Signed-off-by: Tony Lu <tonylu@linux.alibaba.com>
> ---
Thank you.
Acked-by: Karsten Graul <kgraul@linux.ibm.com>
next prev parent reply other threads:[~2022-04-14 8:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-14 7:51 [PATCH net] net/smc: Fix sock leak when release after smc_shutdown() Tony Lu
2022-04-14 8:29 ` Karsten Graul [this message]
2022-04-15 10:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aee77dea-7161-e988-27f8-bbf6c28d048a@linux.ibm.com \
--to=kgraul@linux.ibm.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=tonylu@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox