From: David Hildenbrand <david@redhat.com>
To: Janosch Frank <frankja@linux.ibm.com>,
Cornelia Huck <cohuck@redhat.com>,
Collin Walling <walling@linux.ibm.com>
Cc: kvm@vger.kernel.org, linux-s390@vger.kernel.org,
pbonzini@redhat.com, borntraeger@de.ibm.com,
imbrenda@linux.ibm.com, heiko.carstens@de.ibm.com,
gor@linux.ibm.com, thuth@redhat.com
Subject: Re: [PATCH 2/2] docs: kvm: fix rst formatting
Date: Thu, 25 Jun 2020 09:08:59 +0200 [thread overview]
Message-ID: <afcdae56-5d53-4395-7326-cfce66eef545@redhat.com> (raw)
In-Reply-To: <22b7d435-480e-ac7f-de4f-b992df6c9ebb@linux.ibm.com>
On 25.06.20 09:07, Janosch Frank wrote:
> On 6/25/20 8:34 AM, Cornelia Huck wrote:
>> On Wed, 24 Jun 2020 16:22:00 -0400
>> Collin Walling <walling@linux.ibm.com> wrote:
>>
>>> KVM_CAP_S390_VCPU_RESETS and KVM_CAP_S390_PROTECTED needed
>>> just a little bit of rst touch-up
>>>
>>
>> Fixes: 7de3f1423ff9 ("KVM: s390: Add new reset vcpu API")
>> Fixes: 04ed89dc4aeb ("KVM: s390: protvirt: Add KVM api documentation")
>
> Do we really do that for documentation changes?
Had a similar discussion recently, I prefer to just mention the commits
in the commit message like "Introduced in commit ...".
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2020-06-25 7:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-24 20:21 [PATCH 0/2] s390: Add API Docs for DIAGNOSE 0x318 and fix rst Collin Walling
2020-06-24 20:21 ` [PATCH 1/2] docs: kvm: add documentation for KVM_CAP_S390_DIAG318 Collin Walling
2020-06-25 6:31 ` Cornelia Huck
2020-06-25 7:10 ` David Hildenbrand
2020-06-25 7:16 ` Janosch Frank
2020-06-25 14:42 ` Collin Walling
2020-06-24 20:22 ` [PATCH 2/2] docs: kvm: fix rst formatting Collin Walling
2020-06-25 6:34 ` Cornelia Huck
2020-06-25 7:07 ` Janosch Frank
2020-06-25 7:08 ` David Hildenbrand [this message]
2020-06-25 7:09 ` Cornelia Huck
2020-06-25 14:43 ` Collin Walling
2020-06-25 7:09 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=afcdae56-5d53-4395-7326-cfce66eef545@redhat.com \
--to=david@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=heiko.carstens@de.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=thuth@redhat.com \
--cc=walling@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox