From: "Oscar Salvador (SUSE)" <osalvador@kernel.org>
To: Lorenzo Stoakes <ljs@kernel.org>
Cc: Alexander Gordeev <agordeev@linux.ibm.com>,
Andrew Morton <akpm@linux-foundation.org>,
David Hildenbrand <david@redhat.com>,
Anshuman Khandual <anshuman.khandual@arm.com>,
Oscar Salvador <osalvador@suse.de>,
Wei Yang <richard.weiyang@gmail.com>,
linux-s390@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] mm/page_vma_mapped_walk: Use ptep_get_lockless() for lockless access
Date: Thu, 28 May 2026 16:14:03 +0200 [thread overview]
Message-ID: <ahhNq0pFKvSKZQbR@localhost.localdomain> (raw)
In-Reply-To: <ahglqif-I4TjFK9X@lucifer>
On Thu, May 28, 2026 at 12:24:35PM +0100, Lorenzo Stoakes wrote:
> On Thu, May 28, 2026 at 09:55:07AM +0200, Alexander Gordeev wrote:
> > Switch from ptep_get() to ptep_get_lockless() accessor for
> > PTE reads when no lock is taken.
>
> This is an insufficient commit message that's just saying what you're doing,
> which isn't very useful.
>
> Please explain why you're doing this and what the benefit is please.
Maybe something like
"When not holding the lock, there is a chance that the pte gets modified
under our feet, so we need to use the lockless API to make sure that
the entries remain consistent during the read."
Only arm64 makes use of it though, due to the contpte stuff and being
unable to do it atomically.
--
Oscar Salvador
SUSE Labs
next prev parent reply other threads:[~2026-05-28 14:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-28 7:55 [PATCH v3] mm/page_vma_mapped_walk: Use ptep_get_lockless() for lockless access Alexander Gordeev
2026-05-28 9:09 ` Wei Yang
2026-05-28 11:24 ` Lorenzo Stoakes
2026-05-28 14:14 ` Oscar Salvador (SUSE) [this message]
2026-05-28 14:30 ` Alexander Gordeev
2026-06-01 9:36 ` Lorenzo Stoakes
2026-05-29 17:34 ` Oscar Salvador (SUSE)
2026-06-01 12:10 ` David Hildenbrand (Arm)
2026-06-01 12:15 ` Lorenzo Stoakes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ahhNq0pFKvSKZQbR@localhost.localdomain \
--to=osalvador@kernel.org \
--cc=agordeev@linux.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-s390@vger.kernel.org \
--cc=ljs@kernel.org \
--cc=osalvador@suse.de \
--cc=richard.weiyang@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox