Re: [PATCH rdma-next 13/13] RDMA/selftests: Add rxe_netns_names test

[Jiri Pirko <jiri@resnulli.us>]

Fri, Jul 10, 2026 at 11:56:31AM +0200, sashiko-bot@kernel.org wrote:
>Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
>- [Medium] The test script declares a test plan of 7 tests, but only contains logic to execute 6 tests, causing the script to unconditionally fail.
>- [Medium] The test `TEST_SAME_NETNS_DUP_RENAME` attempts to rename a non-existent device, causing the test to pass for the wrong reason and failing to verify duplicate name rejection.
>--
>
>--- Patch [13]: [PATCH rdma-next 13/13] RDMA/selftests: Add rxe_netns_names test ---
>commit abd8a5c3d2f106017be1f5b869afa69da9c27f3a
>Author: Jiri Pirko <jiri@resnulli.us>
>
>RDMA/selftests: Add rxe_netns_names test
>
>This commit adds a kselftest script that exercises per-netns RDMA device
>naming with RXE. It covers duplicate names across namespaces, move conflict
>handling, move-with-rename, and same-namespace rename requests.
>
>> diff --git a/tools/testing/selftests/rdma/rxe_netns_names.sh b/tools/testing/selftests/rdma/rxe_netns_names.sh
>> new file mode 100755
>> index 0000000000000..a7e57706fdff7
>> --- /dev/null
>> +++ b/tools/testing/selftests/rdma/rxe_netns_names.sh
>
>[ ... ]
>
>> +setup || fail "failed to create net namespaces"
>> +
>> +ktap_print_header
>> +ktap_set_plan 7
>
>[Severity: Medium]
>Does this plan count match the number of tests executed? It looks like the
>script only runs 6 tests, which would cause the test suite to unconditionally
>fail during ktap_finished due to a missing test.

Fixed.


>
>> +
>> +if setup_devs &&
>
>[ ... ]
>
>> +if ! setup_devs; then
>> +	ktap_test_fail "$TEST_SAME_NETNS_DUP_RENAME"
>> +elif rdma dev set "$RXE_A" name "$RXE_SAME" &&
>> +     rdma dev set "$RXE_B" name "$RXE_NEW"; then
>> +	if rdma dev set "$RXE_A" name "$RXE_NEW" >/dev/null 2>&1; then
>
>[Severity: Medium]
>Will this command fail because of a duplicate name, or because the device
>is missing? 
>
>The device originally named RXE_A was just renamed to RXE_SAME in the previous
>condition. If we attempt to rename RXE_A again here, the command fails due to
>the device not being found, which seems to cause the test to pass for the
>wrong reason instead of properly verifying duplicate name rejection.


Fixed.


>
>> +		ktap_test_fail "$TEST_SAME_NETNS_DUP_RENAME"
>> +	elif rdma_dev_exists "" "$RXE_SAME" &&
>> +	     rdma_dev_exists "" "$RXE_NEW"; then
>> +		ktap_test_pass "$TEST_SAME_NETNS_DUP_RENAME"
>
>-- 
>Sashiko AI review · https://sashiko.dev/#/patchset/20260709095532.855647-1-jiri@resnulli.us?part=13