From: Sebastian Ott <sebott@linux.vnet.ibm.com>
To: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
Cc: Peter Oberparleiter <oberpar@linux.vnet.ibm.com>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org,
Tejun Heo <tj@kernel.org>
Subject: Re: [PATCH] s390/cio/chp : Remove deprecated create_singlethread_workqueue
Date: Sat, 16 Jul 2016 12:35:26 +0200 (CEST) [thread overview]
Message-ID: <alpine.LFD.2.20.1607161234360.1961@schleppi> (raw)
In-Reply-To: <20160716084834.GA7728@Karyakshetra>
On Sat, 16 Jul 2016, Bhaktipriya Shridhar wrote:
> The workqueue "chp_wq" is involved in performing pending
> configure tasks for channel paths.
>
> It has a single work item(&cfg_work) and hence doesn't require
> ordering. Also, it is not being used on a memory reclaim path.
> Hence, the singlethreaded workqueue has been replaced with the use of
> system_wq.
>
> System workqueues have been able to handle high level of concurrency
> for a long time now and hence it's not required to have a singlethreaded
> workqueue just to gain concurrency. Unlike a dedicated per-cpu workqueue
> created with create_singlethread_workqueue(), system_wq allows multiple
> work items to overlap executions even on the same CPU; however, a
> per-cpu workqueue doesn't have any CPU locality or global ordering
> guarantee unless the target CPU is explicitly specified and thus the
> increase of local concurrency shouldn't make any difference.
>
> Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
Applied, thanks!
Sebastian
prev parent reply other threads:[~2016-07-16 10:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-16 8:48 [PATCH] s390/cio/chp : Remove deprecated create_singlethread_workqueue Bhaktipriya Shridhar
2016-07-16 10:35 ` Sebastian Ott [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.20.1607161234360.1961@schleppi \
--to=sebott@linux.vnet.ibm.com \
--cc=bhaktipriya96@gmail.com \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=oberpar@linux.vnet.ibm.com \
--cc=schwidefsky@de.ibm.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox