From: Mike Rapoport <rppt@kernel.org>
To: Claudio Imbrenda <imbrenda@linux.ibm.com>
Cc: Christian Borntraeger <borntraeger@linux.ibm.com>,
Janosch Frank <frankja@linux.ibm.com>,
Alexander Gordeev <agordeev@linux.ibm.com>,
David Hildenbrand <david@kernel.org>,
Heiko Carstens <hca@linux.ibm.com>,
Sven Schnelle <svens@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
Vlastimil Babka <vbabka@kernel.org>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, linux-s390@vger.kernel.org
Subject: Re: [PATCH 0/4] KVM: s390: replace page allocator calls with kzalloc()
Date: Thu, 3 Sep 2026 18:22:46 +0300 [thread overview]
Message-ID: <apmQxu1QYcvTyVtS@kernel.org> (raw)
In-Reply-To: <20260903150852.518d6cdc@p-imbrenda>
On Thu, Sep 03, 2026 at 03:08:52PM +0200, Claudio Imbrenda wrote:
> >
> > The only place where __free(kfree) is completely safe is handle_sthyi().
> >
> > In all the other functions using __free(kfree) creates a mix of of goto
> > and cleanup helpers and cleanup docs advise against mixing them:
> >
> > https://docs.kernel.org/core-api/cleanup.html
> >
> > The cleanup paths are quite involved in these functions so using
>
> it looked trivial when I gave it a cursory glance, hence the reason of
> my original request, but...
>
> > __free(kfree) there is really not trivial.
>
> ... yeah, it's actually not trivial at all.
>
>
> maybe refactor the first patch, and leave the rest as it is :)
Yeah, that's what I've been thinking too.
And leave the rest to s390 kvm experts :)
--
Sincerely yours,
Mike.
prev parent reply other threads:[~2026-09-03 15:22 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-02 6:15 [PATCH 0/4] KVM: s390: replace page allocator calls with kzalloc() Mike Rapoport (Microsoft)
2026-09-02 6:15 ` [PATCH 1/4] KVM: s390: Replace get_zeroed_page() with kzalloc() for the STHYI buffer Mike Rapoport (Microsoft)
2026-09-02 6:19 ` sashiko-bot
2026-09-02 6:15 ` [PATCH 2/4] KVM: s390: Replace get_zeroed_page() with kzalloc() for the STSI buffer Mike Rapoport (Microsoft)
2026-09-02 6:22 ` sashiko-bot
2026-09-02 7:55 ` Mike Rapoport
2026-09-02 6:15 ` [PATCH 3/4] KVM: s390: Replace get_zeroed_page() with kzalloc() for the GIB Mike Rapoport (Microsoft)
2026-09-02 6:28 ` sashiko-bot
2026-09-02 6:15 ` [PATCH 4/4] KVM: s390: Replace get_zeroed_page() with kzalloc() for sie_page2 and CMMA Mike Rapoport (Microsoft)
2026-09-02 6:26 ` sashiko-bot
2026-09-02 11:06 ` [PATCH 0/4] KVM: s390: replace page allocator calls with kzalloc() Claudio Imbrenda
2026-09-02 13:17 ` Mike Rapoport
2026-09-02 14:53 ` Claudio Imbrenda
2026-09-03 8:04 ` Mike Rapoport
2026-09-03 13:08 ` Claudio Imbrenda
2026-09-03 15:22 ` Mike Rapoport [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=apmQxu1QYcvTyVtS@kernel.org \
--to=rppt@kernel.org \
--cc=agordeev@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=david@kernel.org \
--cc=frankja@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-s390@vger.kernel.org \
--cc=svens@linux.ibm.com \
--cc=vbabka@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox