Linux s390 Architecture development
 help / color / mirror / Atom feed
From: Mike Rapoport <rppt@kernel.org>
To: Alexander Gordeev <agordeev@linux.ibm.com>
Cc: Heiko Carstens <hca@linux.ibm.com>,
	Vasily Gorbik <gor@linux.ibm.com>,
	Christian Borntraeger <borntraeger@linux.ibm.com>,
	David Hildenbrand <david@kernel.org>,
	Sven Schnelle <svens@linux.ibm.com>,
	Vlastimil Babka <vbabka@kernel.org>,
	linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-mm@kvack.org
Subject: Re: [PATCH 10/14] s390/sclp_cmd: Replace page allocator calls with kzalloc()
Date: Tue, 17 Nov 2026 15:08:26 +0200	[thread overview]
Message-ID: <avxRyt00VGvWlKea@kernel.org> (raw)
In-Reply-To: <545cec68-2444-4dcd-987d-cea05ffe3362-agordeev@linux.ibm.com>

On Mon, Nov 16, 2026 at 04:12:56PM +0100, Alexander Gordeev wrote:
> On Sun, Nov 08, 2026 at 10:58:41AM +0200, Mike Rapoport (Microsoft) wrote:
> > _sclp_get_core_info(), do_chp_configure() and sclp_chp_read_info()
> > allocate the SCCBs used to read the CPU information, to configure a
> > channel path and to read the channel path information.
> > 
> > These buffers can be allocated with kmalloc() as there's nothing special
> > about them to go directly to the page allocator.
> > 
> > kmalloc() provides a better API that does not require ugly casts and
> > kfree() does not need to know the size of the freed object.
> > 
> > Performance difference between kmalloc() and __get_free_pages() is not
> > measurable as both allocators take an object/page from a per-CPU list for
> > fast path allocations.
> > 
> > For the slow path the performance is anyway determined by the amount of
> > reclaim involved rather than by what allocator is used.
> > 
> > While on it, allocate only the amount of memory the SCCB actually
> > requires in _sclp_get_core_info() rather than rounding it up to the next
> > power of two.
> 
> This hints that the SCCB size is less than PAGE_SIZE, which is not the case.
> 
> > An SCCB must be page aligned and kmalloc() guarantees that
> > the alignment of an allocation is at least its largest power of two
> > divisor, so the extended SCCB is still page aligned.
> 
> This implies that the slab size path was taken, which is also not
> the case. Yes, the result is still aligned for PAGE_SIZE, but for
> a different reason ;)
> 
> I would suggest removing this whole paragraph. I can do it if you agree.

I'm sending v2 anyway, will drop it :)
 
> > Replace use of __get_free_pages() and get_zeroed_page() with kzalloc()
> > and free_page[s]() with kfree().
> > 
> > Link: https://lore.kernel.org/all/635405e4-9423-4a25-a6e7-e03c8ea0bcbe@redhat.com
> > Signed-off-by: Mike Rapoport (Microsoft) <rppt@kernel.org>
> > ---
> >  drivers/s390/char/sclp_cmd.c | 12 ++++++------
> >  1 file changed, 6 insertions(+), 6 deletions(-)
> > 
> > diff --git a/drivers/s390/char/sclp_cmd.c b/drivers/s390/char/sclp_cmd.c
> > index 1dc93d945be6f..6aaf1f6a3633f 100644
> > --- a/drivers/s390/char/sclp_cmd.c
> > +++ b/drivers/s390/char/sclp_cmd.c
> > @@ -102,7 +102,7 @@ int _sclp_get_core_info(struct sclp_core_info *info)
> >  		return -EOPNOTSUPP;
> >  
> >  	length = test_facility(140) ? EXT_SCCB_READ_CPU : PAGE_SIZE;
> > -	sccb = (void *)__get_free_pages(GFP_KERNEL | GFP_DMA | __GFP_ZERO, get_order(length));
> > +	sccb = kzalloc(length, GFP_KERNEL | GFP_DMA);
> >  	if (!sccb)
> >  		return -ENOMEM;
> >  	sccb->header.length = length;
> > @@ -119,7 +119,7 @@ int _sclp_get_core_info(struct sclp_core_info *info)
> >  	}
> >  	sclp_fill_core_info(info, sccb);
> >  out:
> > -	free_pages((unsigned long)sccb, get_order(length));
> > +	kfree(sccb);
> >  	return rc;
> >  }
> >  
> > @@ -173,7 +173,7 @@ static int do_chp_configure(sclp_cmdw_t cmd)
> >  
> >  	if (!SCLP_HAS_CHP_RECONFIG)
> >  		return -EOPNOTSUPP;
> > -	sccb = (struct chp_cfg_sccb *)get_zeroed_page(GFP_KERNEL | GFP_DMA);
> > +	sccb = kzalloc(PAGE_SIZE, GFP_KERNEL | GFP_DMA);
> >  	if (!sccb)
> >  		return -ENOMEM;
> >  	sccb->header.length = sizeof(*sccb);
> > @@ -193,7 +193,7 @@ static int do_chp_configure(sclp_cmdw_t cmd)
> >  		break;
> >  	}
> >  out:
> > -	free_page((unsigned long)sccb);
> > +	kfree(sccb);
> >  	return rc;
> >  }
> >  
> > @@ -236,7 +236,7 @@ int sclp_chp_read_info(struct sclp_chp_info *info)
> >  
> >  	if (!SCLP_HAS_CHP_INFO)
> >  		return -EOPNOTSUPP;
> > -	sccb = (struct chp_info_sccb *)get_zeroed_page(GFP_KERNEL | GFP_DMA);
> > +	sccb = kzalloc(PAGE_SIZE, GFP_KERNEL | GFP_DMA);
> >  	if (!sccb)
> >  		return -ENOMEM;
> >  	sccb->header.length = sizeof(*sccb);
> > @@ -253,6 +253,6 @@ int sclp_chp_read_info(struct sclp_chp_info *info)
> >  	memcpy(info->standby, sccb->standby, SCLP_CHP_INFO_MASK_SIZE);
> >  	memcpy(info->configured, sccb->configured, SCLP_CHP_INFO_MASK_SIZE);
> >  out:
> > -	free_page((unsigned long)sccb);
> > +	kfree(sccb);
> >  	return rc;
> >  }
> > 
> > -- 
> > 2.53.0
> > 

-- 
Sincerely yours,
Mike.

  reply	other threads:[~2026-11-17 13:08 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-08  8:58 [PATCH 00/14] s390/sclp: replace page allocator calls with k[mz]alloc() Mike Rapoport (Microsoft)
2026-11-08  8:58 ` [PATCH 01/14] s390/sclp_vt220: Replace get_zeroed_page() with kzalloc() Mike Rapoport (Microsoft)
2026-11-09  9:05   ` sashiko-bot
2026-11-08  8:58 ` [PATCH 02/14] s390/sclp_config: " Mike Rapoport (Microsoft)
2026-11-09  9:05   ` sashiko-bot
2026-11-08  8:58 ` [PATCH 03/14] s390/sclp_pci: " Mike Rapoport (Microsoft)
2026-11-09  9:05   ` sashiko-bot
2026-11-08  8:58 ` [PATCH 04/14] s390/sclp_ctl: " Mike Rapoport (Microsoft)
2026-11-09  9:05   ` sashiko-bot
2026-11-08  8:58 ` [PATCH 05/14] s390/sclp_con: " Mike Rapoport (Microsoft)
2026-11-09  9:05   ` sashiko-bot
2026-11-08  8:58 ` [PATCH 06/14] s390/sclp_tty: " Mike Rapoport (Microsoft)
2026-11-09  9:05   ` sashiko-bot
2026-11-08  8:58 ` [PATCH 07/14] s390/sclp: Replace __get_free_page() with kmalloc() Mike Rapoport (Microsoft)
2026-11-09  9:05   ` sashiko-bot
2026-11-08  8:58 ` [PATCH 08/14] s390/sclp_sdias: " Mike Rapoport (Microsoft)
2026-11-09  9:05   ` sashiko-bot
2026-11-08  8:58 ` [PATCH 09/14] s390/sclp_sd: " Mike Rapoport (Microsoft)
2026-11-09  9:05   ` sashiko-bot
2026-11-08  8:58 ` [PATCH 10/14] s390/sclp_cmd: Replace page allocator calls with kzalloc() Mike Rapoport (Microsoft)
2026-11-09  9:05   ` sashiko-bot
2026-11-16 15:12   ` Alexander Gordeev
2026-11-17 13:08     ` Mike Rapoport [this message]
2026-11-16 15:22   ` Heiko Carstens
2026-11-17 13:08     ` Mike Rapoport
2026-11-08  8:58 ` [PATCH 11/14] s390/sclp_cpi: Replace get_zeroed_page() " Mike Rapoport (Microsoft)
2026-11-09  9:05   ` sashiko-bot
2026-11-08  8:58 ` [PATCH 12/14] s390/sclp_ftp: " Mike Rapoport (Microsoft)
2026-11-09  9:05   ` sashiko-bot
2026-11-16 15:26   ` Heiko Carstens
2026-11-17 13:09     ` Mike Rapoport
2026-11-16 15:27   ` Alexander Gordeev
2026-11-08  8:58 ` [PATCH 13/14] s390/sclp_mem: Replace page allocator calls with k[mz]alloc() Mike Rapoport (Microsoft)
2026-11-09  9:05   ` sashiko-bot
2026-11-08  8:58 ` [PATCH 14/14] s390/sclp_ap: Replace get_zeroed_page() with kzalloc() Mike Rapoport (Microsoft)
2026-11-09  9:05   ` sashiko-bot
2026-11-16 15:28 ` [PATCH 00/14] s390/sclp: replace page allocator calls with k[mz]alloc() Heiko Carstens

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=avxRyt00VGvWlKea@kernel.org \
    --to=rppt@kernel.org \
    --cc=agordeev@linux.ibm.com \
    --cc=borntraeger@linux.ibm.com \
    --cc=david@kernel.org \
    --cc=gor@linux.ibm.com \
    --cc=hca@linux.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=svens@linux.ibm.com \
    --cc=vbabka@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox