From: Paolo Abeni <pabeni@redhat.com>
To: Eric Dumazet <edumazet@google.com>, David Ahern <dsahern@kernel.org>
Cc: Jakub Kicinski <kuba@kernel.org>, Jiri Pirko <jiri@resnulli.us>,
David Miller <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>,
Steffen Klassert <steffen.klassert@secunet.com>,
jreuter@yaina.de, razor@blackwall.org,
Karsten Graul <kgraul@linux.ibm.com>,
ivecera@redhat.com, Jon Maloy <jmaloy@redhat.com>,
Ying Xue <ying.xue@windriver.com>,
Xin Long <lucien.xin@gmail.com>, Arnd Bergmann <arnd@arndb.de>,
Yajun Deng <yajun.deng@linux.dev>,
Antoine Tenart <atenart@kernel.org>,
richardsonnick@google.com, Heiner Kallweit <hkallweit1@gmail.com>,
linux-hams@vger.kernel.org, dev@openvswitch.org,
linux-s390@vger.kernel.org,
tipc-discussion@lists.sourceforge.net
Subject: Re: [PATCH net-next] net: rename reference+tracking helpers
Date: Thu, 09 Jun 2022 13:49:48 +0200 [thread overview]
Message-ID: <b00ab3c4a12fb11ed95b2a4634e50e3cba10ec28.camel@redhat.com> (raw)
In-Reply-To: <CANn89i+RCCXQDVVTB+hHasGmjdXwdm8CvkPQv3nYSLgr=MYmpA@mail.gmail.com>
On Wed, 2022-06-08 at 16:00 -0700, Eric Dumazet wrote:
> On Wed, Jun 8, 2022 at 3:58 PM David Ahern <dsahern@kernel.org> wrote:
> >
> > On 6/8/22 8:58 AM, Jakub Kicinski wrote:
> > > IMO to encourage use of the track-capable API we could keep their names
> > > short and call the legacy functions __netdev_hold() as I mentioned or
> > > maybe netdev_hold_notrack().
> >
> > I like that option. Similar to the old nla_parse functions that were
> > renamed with _deprecated - makes it easier to catch new uses.
>
> I think we need to clearly document the needed conversions for future
> bugfix backports.
>
To be on the same page: do you think we need something under
Documentation with this patch? or with the later dev_hold rename? or
did I misunderstood completely?
Thanks!
Paolo
next prev parent reply other threads:[~2022-06-09 11:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-08 4:39 [PATCH net-next] net: rename reference+tracking helpers Jakub Kicinski
2022-06-08 8:27 ` Jiri Pirko
2022-06-08 14:58 ` Jakub Kicinski
2022-06-08 22:58 ` David Ahern
2022-06-08 23:00 ` Eric Dumazet
2022-06-09 11:49 ` Paolo Abeni [this message]
2022-06-09 13:53 ` Eric Dumazet
2022-06-09 3:29 ` Jakub Kicinski
2022-06-09 4:40 ` Jiri Pirko
2022-06-10 5:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b00ab3c4a12fb11ed95b2a4634e50e3cba10ec28.camel@redhat.com \
--to=pabeni@redhat.com \
--cc=arnd@arndb.de \
--cc=atenart@kernel.org \
--cc=davem@davemloft.net \
--cc=dev@openvswitch.org \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=ivecera@redhat.com \
--cc=jiri@resnulli.us \
--cc=jmaloy@redhat.com \
--cc=jreuter@yaina.de \
--cc=kgraul@linux.ibm.com \
--cc=kuba@kernel.org \
--cc=linux-hams@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=lucien.xin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=razor@blackwall.org \
--cc=richardsonnick@google.com \
--cc=steffen.klassert@secunet.com \
--cc=tipc-discussion@lists.sourceforge.net \
--cc=yajun.deng@linux.dev \
--cc=ying.xue@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox