From: Thomas Huth <thuth@redhat.com>
To: Janosch Frank <frankja@linux.ibm.com>, kvm@vger.kernel.org
Cc: linux-s390@vger.kernel.org, david@redhat.com
Subject: Re: [kvm-unit-tests PATCH 3/3] s390x: Add storage key removal facility
Date: Wed, 28 Aug 2019 09:56:04 +0200 [thread overview]
Message-ID: <b0349845-b759-2b28-7ba3-d3fbf6515dda@redhat.com> (raw)
In-Reply-To: <f0cddac0-a574-1aeb-69c6-b9d67f2dfd97@linux.ibm.com>
[-- Attachment #1.1: Type: text/plain, Size: 883 bytes --]
On 28/08/2019 08.26, Janosch Frank wrote:
> On 8/27/19 7:58 PM, Thomas Huth wrote:
[...]
>> Anyway, I've now also checked this patch in the CI:
>>
>> diff a/s390x/Makefile b/s390x/Makefile
>> --- a/s390x/Makefile
>> +++ b/s390x/Makefile
>> @@ -25,7 +25,7 @@ CFLAGS += -std=gnu99
>> CFLAGS += -ffreestanding
>> CFLAGS += -I $(SRCDIR)/lib -I $(SRCDIR)/lib/s390x -I lib
>> CFLAGS += -O2
>> -CFLAGS += -march=z900
>> +CFLAGS += -march=z10
>> CFLAGS += -fno-delete-null-pointer-checks
>> LDFLAGS += -nostdlib -Wl,--build-id=none
>>
>> ... and it also seems to work fine with the TCG there:
>>
>> https://gitlab.com/huth/kvm-unit-tests/-/jobs/281450598
>>
>> So I think you can simply change it in the Makefile instead.
>
> z10 or directly something higher?
zEC12 seems to work, too:
https://gitlab.com/huth/kvm-unit-tests/-/jobs/281833366
Thomas
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2019-08-28 7:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-27 13:49 [kvm-unit-tests PATCH 0/3] s390x: Add skey removal facility test Janosch Frank
2019-08-27 13:49 ` [kvm-unit-tests PATCH 1/3] s390x: Move pfmf to lib and make address void Janosch Frank
2019-08-27 15:23 ` Thomas Huth
2019-08-27 13:49 ` [kvm-unit-tests PATCH 2/3] s390x: Storage key library functions now take void ptr addresses Janosch Frank
2019-08-27 15:28 ` Thomas Huth
2019-08-27 13:49 ` [kvm-unit-tests PATCH 3/3] s390x: Add storage key removal facility Janosch Frank
2019-08-27 17:58 ` Thomas Huth
2019-08-28 6:26 ` Janosch Frank
2019-08-28 7:56 ` Thomas Huth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b0349845-b759-2b28-7ba3-d3fbf6515dda@redhat.com \
--to=thuth@redhat.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox