Re: [PATCH 1/4] vfio-mdev: allow building the samples into the kernel

[Anthony Krowiak <akrowiak@linux.ibm.com>]

On 1/10/23 4:10 AM, Christoph Hellwig wrote:
> There is nothing in the vfio-mdev sample drivers that requires building
> them as modules, so remove that restriction.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
>   samples/Kconfig | 16 ++++++++--------
>   1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/samples/Kconfig b/samples/Kconfig
> index 0d81c00289ee36..f1b8d4ff123036 100644
> --- a/samples/Kconfig
> +++ b/samples/Kconfig
> @@ -184,23 +184,23 @@ config SAMPLE_UHID
>   	  Build UHID sample program.
>   
>   config SAMPLE_VFIO_MDEV_MTTY
> -	tristate "Build VFIO mtty example mediated device sample code -- loadable modules only"
> -	depends on VFIO_MDEV && m
> +	tristate "Build VFIO mtty example mediated device sample code"
> +	depends on VFIO_MDEV


Admittedly, I'm not very fluent with Kconfig, but in patch 2 you stated, 
"VFIO_MDEV is just a library with helpers for the drivers. Stop making 
it a user choice and just select it by the drivers that use the 
helpers". Why are you not selecting it here?


>   	help
>   	  Build a virtual tty sample driver for use as a VFIO
>   	  mediated device
>   
>   config SAMPLE_VFIO_MDEV_MDPY
> -	tristate "Build VFIO mdpy example mediated device sample code -- loadable modules only"
> -	depends on VFIO_MDEV && m
> +	tristate "Build VFIO mdpy example mediated device sample code"
> +	depends on VFIO_MDEV
>   	help
>   	  Build a virtual display sample driver for use as a VFIO
>   	  mediated device.  It is a simple framebuffer and supports
>   	  the region display interface (VFIO_GFX_PLANE_TYPE_REGION).
>   
>   config SAMPLE_VFIO_MDEV_MDPY_FB
> -	tristate "Build VFIO mdpy example guest fbdev driver -- loadable module only"
> -	depends on FB && m
> +	tristate "Build VFIO mdpy example guest fbdev driver"
> +	depends on FB
>   	select FB_CFB_FILLRECT
>   	select FB_CFB_COPYAREA
>   	select FB_CFB_IMAGEBLIT
> @@ -208,8 +208,8 @@ config SAMPLE_VFIO_MDEV_MDPY_FB
>   	  Guest fbdev driver for the virtual display sample driver.
>   
>   config SAMPLE_VFIO_MDEV_MBOCHS
> -	tristate "Build VFIO mdpy example mediated device sample code -- loadable modules only"
> -	depends on VFIO_MDEV && m
> +	tristate "Build VFIO mdpy example mediated device sample code"
> +	depends on VFIO_MDEV
>   	select DMA_SHARED_BUFFER
>   	help
>   	  Build a virtual display sample driver for use as a VFIO