public inbox for linux-s390@vger.kernel.org
 help / color / mirror / Atom feed
From: Tony Krowiak <akrowiak@linux.ibm.com>
To: Harald Freudenberger <freude@linux.ibm.com>, linux-s390@vger.kernel.org
Cc: borntraeger@linux.ibm.com, cohuck@redhat.com,
	mjrosato@linux.ibm.com, jjherne@linux.ibm.com,
	pasic@linux.ibm.com
Subject: Re: [PATCH 2/2] s390/vfio-ap: add status attribute to AP queue device's sysfs dir
Date: Mon, 1 Nov 2021 11:48:58 -0400	[thread overview]
Message-ID: <b8e60398-baad-ced1-7687-e5bf90ab52c5@linux.ibm.com> (raw)
In-Reply-To: <5ce1ab5f-da7b-451d-ebfe-08919a56f5d8@linux.ibm.com>



On 10/28/21 3:40 AM, Harald Freudenberger wrote:
> On 27.10.21 18:48, Tony Krowiak wrote:
>> This patch adds a sysfs 'status' attribute to a queue device when it is
>> bound to the vfio_ap device driver. The field displays a string indicating
>> the status of the queue device:
>>
>> Status String:  Indicates:
>> -------------   ---------
>> "assigned"      the queue is assigned to an mdev, but is not in use by a
>>                  KVM guest.
>> "in use"        the queue is assigned to an mdev and is in use by a KVM
>>                  guest.
>> "unassigned"    the queue is not assigned to an mdev.
>>
>> The status string will be displayed by the 'lszcrypt' command if the queue
>> device is bound to the vfio_ap device driver.
>>
>> Signed-off-by: Harald Freudenberger <freude@linux.ibm.com>
>> [akrowiak@linux.ibm.com: added check for queue in use by guest]
>> Signed-off-by: Tony Krowiak <akrowiak@linux.ibm.com>Looks good to me, add my "Reviewed-by: Harald Freudenberger <freude@linux.ibm.com>"

You already have a Signed-off-by since you created the original version 
of this
patch. I added my Signed-off-by for adding the "in use" status value. 
Should I still
add a Reviewed-by for you?



      reply	other threads:[~2021-11-01 15:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-27 16:48 [PATCH 0/2] s390/vfio-ap: add status attribute to AP queue device's sysfs dir Tony Krowiak
2021-10-27 16:48 ` [PATCH 1/2] s390/vfio-ap: s390/crypto: fix all kernel-doc warnings Tony Krowiak
2021-10-27 16:48 ` [PATCH 2/2] s390/vfio-ap: add status attribute to AP queue device's sysfs dir Tony Krowiak
2021-10-28  7:40   ` Harald Freudenberger
2021-11-01 15:48     ` Tony Krowiak [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b8e60398-baad-ced1-7687-e5bf90ab52c5@linux.ibm.com \
    --to=akrowiak@linux.ibm.com \
    --cc=borntraeger@linux.ibm.com \
    --cc=cohuck@redhat.com \
    --cc=freude@linux.ibm.com \
    --cc=jjherne@linux.ibm.com \
    --cc=linux-s390@vger.kernel.org \
    --cc=mjrosato@linux.ibm.com \
    --cc=pasic@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox