From: Nicolin Chen <nicolinc@nvidia.com>
To: <joro@8bytes.org>, <jgg@nvidia.com>, <kevin.tian@intel.com>
Cc: <suravee.suthikulpanit@amd.com>, <will@kernel.org>,
<robin.murphy@arm.com>, <sven@kernel.org>, <j@jannau.net>,
<robin.clark@oss.qualcomm.com>, <m.szyprowski@samsung.com>,
<krzk@kernel.org>, <dwmw2@infradead.org>,
<baolu.lu@linux.intel.com>, <yong.wu@mediatek.com>,
<matthias.bgg@gmail.com>,
<angelogioacchino.delregno@collabora.com>,
<tjeznach@rivosinc.com>, <pjw@kernel.org>, <palmer@dabbelt.com>,
<aou@eecs.berkeley.edu>, <heiko@sntech.de>,
<schnelle@linux.ibm.com>, <mjrosato@linux.ibm.com>,
<orsonzhai@gmail.com>, <baolin.wang@linux.alibaba.com>,
<wens@csie.org>, <jernej.skrabec@gmail.com>,
<samuel@sholland.org>, <thierry.reding@gmail.com>,
<jonathanh@nvidia.com>, <jean-philippe@linaro.org>,
<iommu@lists.linux.dev>, <linux-kernel@vger.kernel.org>,
<asahi@lists.linux.dev>, <linux-arm-kernel@lists.infradead.org>,
<linux-arm-msm@vger.kernel.org>,
<linux-samsung-soc@vger.kernel.org>,
<linux-mediatek@lists.infradead.org>,
<linux-riscv@lists.infradead.org>,
<linux-rockchip@lists.infradead.org>,
<linux-s390@vger.kernel.org>, <linux-sunxi@lists.linux.dev>,
<linux-tegra@vger.kernel.org>, <virtualization@lists.linux.dev>,
<patches@lists.linux.dev>
Subject: [PATCH v2 4/6] iommu/amd: Set release_domain to blocked_domain
Date: Wed, 22 Oct 2025 19:21:07 -0700 [thread overview]
Message-ID: <c1ffdeb056eb168800f108c8e4e8564e9589f7f9.1761017765.git.nicolinc@nvidia.com> (raw)
In-Reply-To: <cover.1761017765.git.nicolinc@nvidia.com>
The set_dev_pasid for a release domain never gets called anyhow. So, there
is no point in defining a separate release_domain from the blocked_domain.
Simply reuse the blocked_domain.
Suggested-by: Jason Gunthorpe <jgg@nvidia.com>
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
Signed-off-by: Nicolin Chen <nicolinc@nvidia.com>
---
drivers/iommu/amd/iommu.c | 10 +---------
1 file changed, 1 insertion(+), 9 deletions(-)
diff --git a/drivers/iommu/amd/iommu.c b/drivers/iommu/amd/iommu.c
index 2e1865daa1cee..6f4559eb5121a 100644
--- a/drivers/iommu/amd/iommu.c
+++ b/drivers/iommu/amd/iommu.c
@@ -2685,14 +2685,6 @@ void amd_iommu_init_identity_domain(void)
protection_domain_init(&identity_domain);
}
-/* Same as blocked domain except it supports only ops->attach_dev() */
-static struct iommu_domain release_domain = {
- .type = IOMMU_DOMAIN_BLOCKED,
- .ops = &(const struct iommu_domain_ops) {
- .attach_dev = blocked_domain_attach_device,
- }
-};
-
static int amd_iommu_attach_device(struct iommu_domain *dom,
struct device *dev)
{
@@ -3042,7 +3034,7 @@ static const struct iommu_dirty_ops amd_dirty_ops = {
const struct iommu_ops amd_iommu_ops = {
.capable = amd_iommu_capable,
.blocked_domain = &blocked_domain,
- .release_domain = &release_domain,
+ .release_domain = &blocked_domain,
.identity_domain = &identity_domain.domain,
.domain_alloc_paging_flags = amd_iommu_domain_alloc_paging_flags,
.domain_alloc_sva = amd_iommu_domain_alloc_sva,
--
2.43.0
next prev parent reply other threads:[~2025-10-23 2:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-23 2:21 [PATCH v2 0/6] iommu: Pass in old_domain pointer to attach_dev Nicolin Chen
2025-10-23 2:21 ` [PATCH v2 1/6] iommu: Generic support for RMRs during device release Nicolin Chen
2025-10-23 4:43 ` Baolu Lu
2025-10-23 2:21 ` [PATCH v2 2/6] iommu/arm-smmu-v3: Set release_domain to arm_smmu_blocked_domain Nicolin Chen
2025-10-23 2:21 ` [PATCH v2 3/6] iommu/exynos-iommu: Set release_domain to exynos_identity_domain Nicolin Chen
2025-10-23 2:21 ` Nicolin Chen [this message]
2025-10-23 2:21 ` [PATCH v2 5/6] iommu: Do not revert set_domain for the last gdev Nicolin Chen
2025-10-23 4:50 ` Baolu Lu
2025-10-23 2:21 ` [PATCH v2 6/6] iommu: Pass in old domain to attach_dev callback functions Nicolin Chen
2025-10-23 4:58 ` Baolu Lu
2025-10-27 12:55 ` [PATCH v2 0/6] iommu: Pass in old_domain pointer to attach_dev Jörg Rödel
2025-12-19 8:10 ` patchwork-bot+linux-riscv
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c1ffdeb056eb168800f108c8e4e8564e9589f7f9.1761017765.git.nicolinc@nvidia.com \
--to=nicolinc@nvidia.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=aou@eecs.berkeley.edu \
--cc=asahi@lists.linux.dev \
--cc=baolin.wang@linux.alibaba.com \
--cc=baolu.lu@linux.intel.com \
--cc=dwmw2@infradead.org \
--cc=heiko@sntech.de \
--cc=iommu@lists.linux.dev \
--cc=j@jannau.net \
--cc=jean-philippe@linaro.org \
--cc=jernej.skrabec@gmail.com \
--cc=jgg@nvidia.com \
--cc=jonathanh@nvidia.com \
--cc=joro@8bytes.org \
--cc=kevin.tian@intel.com \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=linux-tegra@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=matthias.bgg@gmail.com \
--cc=mjrosato@linux.ibm.com \
--cc=orsonzhai@gmail.com \
--cc=palmer@dabbelt.com \
--cc=patches@lists.linux.dev \
--cc=pjw@kernel.org \
--cc=robin.clark@oss.qualcomm.com \
--cc=robin.murphy@arm.com \
--cc=samuel@sholland.org \
--cc=schnelle@linux.ibm.com \
--cc=suravee.suthikulpanit@amd.com \
--cc=sven@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=tjeznach@rivosinc.com \
--cc=virtualization@lists.linux.dev \
--cc=wens@csie.org \
--cc=will@kernel.org \
--cc=yong.wu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox