From: Stefan Haberland <sth@linux.ibm.com>
To: "Carlos López" <clopez@suse.de>, linux-s390@vger.kernel.org
Cc: Jan Hoeppner <hoeppner@linux.ibm.com>,
Heiko Carstens <hca@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
Alexander Gordeev <agordeev@linux.ibm.com>,
Christian Borntraeger <borntraeger@linux.ibm.com>,
Sven Schnelle <svens@linux.ibm.com>, Jens Axboe <axboe@kernel.dk>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] s390/dasd: fix error checks in dasd_copy_pair_store()
Date: Mon, 1 Jul 2024 12:58:12 +0200 [thread overview]
Message-ID: <c41c53e4-aa6d-47b7-b928-0c1b9e8dcdc3@linux.ibm.com> (raw)
In-Reply-To: <20240527135044.27427-1-clopez@suse.de>
Am 27.05.24 um 15:50 schrieb Carlos López:
> dasd_add_busid() can return an error via ERR_PTR() if an allocation
> fails. However, two callsites in dasd_copy_pair_store() do not check
> the result, potentially resulting in a NULL pointer dereference. Fix
> this by checking the result with IS_ERR() and returning the error up
> the stack.
>
> Fixes: a91ff09d39f9b ("s390/dasd: add copy pair setup")
> Signed-off-by: Carlos López <clopez@suse.de>
> ---
Applied, thanks.
prev parent reply other threads:[~2024-07-01 10:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-27 13:50 [PATCH] s390/dasd: fix error checks in dasd_copy_pair_store() Carlos López
2024-07-01 10:58 ` Stefan Haberland [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c41c53e4-aa6d-47b7-b928-0c1b9e8dcdc3@linux.ibm.com \
--to=sth@linux.ibm.com \
--cc=agordeev@linux.ibm.com \
--cc=axboe@kernel.dk \
--cc=borntraeger@linux.ibm.com \
--cc=clopez@suse.de \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=hoeppner@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=svens@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox