Re: [PATCH v3 1/2] KVM: s390: fix access register usage in ioctls

[Janosch Frank <frankja@linux.ibm.com>]

On 2/20/24 15:15, Christian Borntraeger wrote:
> 
> 
> Am 16.02.24 um 22:36 schrieb Eric Farman:
>> The routine ar_translation() can be reached by both the instruction
>> intercept path (where the access registers had been loaded with the
>> guest register contents), and the MEM_OP ioctls (which hadn't).
>> Since this routine saves the current registers to vcpu->run,
>> this routine erroneously saves host registers into the guest space.
>>
>> Introduce a boolean in the kvm_vcpu_arch struct to indicate whether
>> the registers contain guest contents. If they do (the instruction
>> intercept path), the save can be performed and the AR translation
>> is done just as it is today. If they don't (the MEM_OP path), the
>> AR can be read from vcpu->run without stashing the current contents.
>>
>> Signed-off-by: Eric Farman <farman@linux.ibm.com>
> 

Just spoke with Christian since that's a mixed signal.

To move this over the s390 tree:
> Acked-by: Christian Borntraeger <borntraeger@linux.ibm.com>

For the Patch in general:
> Reviewed-by: Christian Borntraeger <borntraeger@linux.ibm.com>