From: Christian Borntraeger <borntraeger@de.ibm.com>
To: Claudio Imbrenda <imbrenda@linux.ibm.com>, kvm@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org,
frankja@linux.ibm.com, nrb@linux.ibm.com, nsg@linux.ibm.com,
hca@linux.ibm.com, gor@linux.ibm.com, svens@linux.ibm.com,
agordeev@linux.ibm.com,
Gerald Schaefer <gerald.schaefer@linux.ibm.com>
Subject: Re: [PATCH v1 1/1] KVM: s390/mm: Properly reset no-dat
Date: Thu, 9 Nov 2023 14:11:48 +0100 [thread overview]
Message-ID: <c64f27ac-3367-c58c-d8d5-075e7bf6b7f8@de.ibm.com> (raw)
In-Reply-To: <20231109123624.37314-1-imbrenda@linux.ibm.com>
Am 09.11.23 um 13:36 schrieb Claudio Imbrenda:
> When the CMMA state needs to be reset, the no-dat bit also needs to be
> reset. Failure to do so could cause issues in the guest, since the
> guest expects the bit to be cleared after a reset.
This happens during reset of a guest (or whenever QEMU calls the CLR_CMMA thingi).
I think after reset a normal Linux guest has no DAT tables and very likely
a cpu reset (with explicit full guest flush) will happen. It will very likely
also set the CMMA state during boot before setting up its DAT tables.
So for the normal reboot this should be ok. But I can imagine cases that would
not be ok. So maybe add cc stable?
next prev parent reply other threads:[~2023-11-09 13:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-09 12:36 [PATCH v1 1/1] KVM: s390/mm: Properly reset no-dat Claudio Imbrenda
2023-11-09 12:44 ` Claudio Imbrenda
2023-11-09 13:11 ` Christian Borntraeger [this message]
2023-11-14 16:24 ` Nico Boehr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c64f27ac-3367-c58c-d8d5-075e7bf6b7f8@de.ibm.com \
--to=borntraeger@de.ibm.com \
--cc=agordeev@linux.ibm.com \
--cc=frankja@linux.ibm.com \
--cc=gerald.schaefer@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=nrb@linux.ibm.com \
--cc=nsg@linux.ibm.com \
--cc=svens@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox