From: Karsten Graul <kgraul@linux.ibm.com>
To: "D. Wythe" <alibuda@linux.alibaba.com>
Cc: kuba@kernel.org, davem@davemloft.net, netdev@vger.kernel.org,
linux-s390@vger.kernel.org, linux-rdma@vger.kernel.org
Subject: Re: [PATCH net-next] net/smc: return ETIMEDOUT when smc_connect_clc() timeout
Date: Tue, 15 Feb 2022 14:02:37 +0100 [thread overview]
Message-ID: <c85310ed-fd9c-fa8c-88d2-862b5d99dbbe@linux.ibm.com> (raw)
In-Reply-To: <1644913490-21594-1-git-send-email-alibuda@linux.alibaba.com>
On 15/02/2022 09:24, D. Wythe wrote:
> From: "D. Wythe" <alibuda@linux.alibaba.com>
>
> When smc_connect_clc() times out, it will return -EAGAIN(tcp_recvmsg
> retuns -EAGAIN while timeout), then this value will passed to the
> application, which is quite confusing to the applications, makes
> inconsistency with TCP.
>
> From the manual of connect, ETIMEDOUT is more suitable, and this patch
> try convert EAGAIN to ETIMEDOUT in that case.
You say that the sock_recvmsg() in smc_clc_wait_msg() returns -EAGAIN?
Is there a reason why you translate it in __smc_connect() and not already in
smc_clc_wait_msg() after the call to sock_recvmsg()?
next prev parent reply other threads:[~2022-02-15 13:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-15 8:24 [PATCH net-next] net/smc: return ETIMEDOUT when smc_connect_clc() timeout D. Wythe
2022-02-15 13:02 ` Karsten Graul [this message]
2022-02-16 3:13 ` D. Wythe
2022-02-16 10:23 ` Karsten Graul
2022-02-17 4:32 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c85310ed-fd9c-fa8c-88d2-862b5d99dbbe@linux.ibm.com \
--to=kgraul@linux.ibm.com \
--cc=alibuda@linux.alibaba.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox