Re: [PATCH v1 02/20] s390/ap/zcrypt: Rework AP message buffer allocation

[Holger Dengler <dengler@linux.ibm.com>]

On 23/02/2025 10:54, Harald Freudenberger wrote:
> Slight rework on the way how AP message buffers are allocated.
> Instead of having multiple places with kmalloc() calls all
> the AP message buffers are now allocated and freed on exactyl
> one place ap_init_apmsg() allocates the current AP bus max
> limit of ap_max_msg_size (defaults to 12KB). The preparation
> functions only check for their payload to fit in. The AP
> message buffer is freed in ap_release_apmsg().

This patch reverts some non-neccessary changes from the previous one. Please clean this up.

Beside that,
Reviewed-by: Holger Dengler <dengler@linux.ibm.com>

> 
> Signed-off-by: Harald Freudenberger <freude@linux.ibm.com>
> ---
>  drivers/s390/crypto/ap_bus.c           | 30 ++++++++++++++++
>  drivers/s390/crypto/ap_bus.h           | 21 ++---------
>  drivers/s390/crypto/zcrypt_api.c       | 49 +++++++++++++++-----------
>  drivers/s390/crypto/zcrypt_msgtype50.c | 22 ++++++------
>  drivers/s390/crypto/zcrypt_msgtype6.c  | 46 ++++++++++++------------
>  5 files changed, 96 insertions(+), 72 deletions(-)

-- 
Mit freundlichen Grüßen / Kind regards
Holger Dengler
--
IBM Systems, Linux on IBM Z Development
dengler@linux.ibm.com