From: David Laight <David.Laight@ACULAB.COM>
To: 'Christoph Hellwig' <hch@lst.de>, Andy Lutomirski <luto@kernel.org>
Cc: Arnd Bergmann <arnd@kernel.org>,
Ryan Houdek <sonicadvance1@gmail.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Arnd Bergmann <arnd@arndb.de>,
Christian Brauner <christian.brauner@ubuntu.com>,
Andrew Morton <akpm@linux-foundation.org>,
Minchan Kim <minchan@kernel.org>,
Aleksa Sarai <cyphar@cyphar.com>,
Sargun Dhillon <sargun@sargun.me>,
Miklos Szeredi <mszeredi@redhat.com>,
Vincenzo Frascino <vincenzo.frascino@arm.com>,
Amanieu d'Antras <amanieu@gmail.com>,
Willem de Bruijn <willemb@google.com>,
YueHaibing <yuehaibing@huawei.com>,
Xiaoming Ni <nixiaoming@huawei.com>,
Heiko Carstens <hca@linux.ibm.com>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Joe Perches <joe@perches.com>, Jan Kara <jack@suse.cz>,
David Rientjes <rientjes@google.com>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
"David S. Miller" <davem@davemloft.net>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Linux FS-devel Mailing List <linux-fsdevel@vger.kernel.org>,
Linux API <linux-api@vger.kernel.org>,
linux-arch <linux-arch@vger.kernel.org>
Subject: RE: [PATCH] Adds a new ioctl32 syscall for backwards compatibility layers
Date: Sun, 17 Jan 2021 18:31:36 +0000 [thread overview]
Message-ID: <cc3ce5e484f041948cb008f7508c968b@AcuMS.aculab.com> (raw)
In-Reply-To: <20210116090721.GA30277@lst.de>
From: Christoph Hellwig
> Sent: 16 January 2021 09:07
...
> > I personally would like to see in_compat_syscall() go away,
> > but some other people (Hi, Christoph!) disagree, and usage seems to be
> > increasing, not decreasing.
>
> I'm absolutely against it going away. in_compat_syscall helped to
> remove so much crap compared to the explicit compat syscalls.
The only other real option is to pass the 'syscall type' explicitly
through all the layers into every piece of code that might need it.
So passing it as a 'parameter' that is (probably) current->syscall_type
does make sense.
It might even make sense have separate bits for the required emulations.
So you'd have separate bits for '32bit pointers' and '64bit items 32bit
aligned' (etc).
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)
next prev parent reply other threads:[~2021-01-17 18:31 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-06 6:48 [PATCH] Adds a new ioctl32 syscall for backwards compatibility layers sonicadvance1
2021-01-06 8:48 ` Arnd Bergmann
2021-01-15 2:21 ` Ryan Houdek
[not found] ` <CABnRqDfQ5Qfa2ybut0qXcKuYnsMcG7+9gqjL-e7nZF1bkvhPRw@mail.gmail.com>
2021-01-15 9:00 ` Arnd Bergmann
2021-01-16 0:07 ` Andy Lutomirski
2021-01-16 9:07 ` Christoph Hellwig
2021-01-17 18:31 ` David Laight [this message]
2021-01-06 22:57 ` Amanieu d'Antras
2021-01-15 7:02 ` sonicadvance1
2021-01-15 7:17 ` [PATCH v2] " sonicadvance1
2021-01-15 20:01 ` [PATCH] " David Laight
2021-01-15 22:17 ` Arnd Bergmann
2021-01-15 22:23 ` Rich Felker
2021-01-15 22:39 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cc3ce5e484f041948cb008f7508c968b@AcuMS.aculab.com \
--to=david.laight@aculab.com \
--cc=acme@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=amanieu@gmail.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=christian.brauner@ubuntu.com \
--cc=cyphar@cyphar.com \
--cc=davem@davemloft.net \
--cc=ebiederm@xmission.com \
--cc=hca@linux.ibm.com \
--cc=hch@lst.de \
--cc=jack@suse.cz \
--cc=joe@perches.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=minchan@kernel.org \
--cc=mszeredi@redhat.com \
--cc=nixiaoming@huawei.com \
--cc=rientjes@google.com \
--cc=sargun@sargun.me \
--cc=sonicadvance1@gmail.com \
--cc=vincenzo.frascino@arm.com \
--cc=viro@zeniv.linux.org.uk \
--cc=will@kernel.org \
--cc=willemb@google.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox