public inbox for linux-s390@vger.kernel.org
 help / color / mirror / Atom feed
From: Benjamin Block <bblock@linux.ibm.com>
To: "James E.J. Bottomley" <jejb@linux.ibm.com>,
	"Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Julian Wiedmann <jwi@linux.ibm.com>,
	Benjamin Block <bblock@linux.ibm.com>,
	Steffen Maier <maier@linux.ibm.com>,
	Heiko Carstens <heiko.carstens@de.ibm.com>,
	Vasily Gorbik <gor@linux.ibm.com>,
	Christian Borntraeger <borntraeger@de.ibm.com>,
	Fedor Loshakov <loshakov@linux.ibm.com>,
	linux-scsi@vger.kernel.org, linux-s390@vger.kernel.org
Subject: [PATCH 5/7] zfcp: clean up zfcp_erp_action_ready()
Date: Fri,  3 Jul 2020 15:20:01 +0200	[thread overview]
Message-ID: <d1bb04322f240dee32f4c4a551bc93bc736f4b01.1593780621.git.bblock@linux.ibm.com> (raw)
In-Reply-To: <cover.1593780621.git.bblock@linux.ibm.com>

From: Julian Wiedmann <jwi@linux.ibm.com>

We already maintain a pointer to act->adapter. Use it consistently to
avoid any confusion about whose ->erp_ready_head and ->erp_ready_wq
we are accessing.

Signed-off-by: Julian Wiedmann <jwi@linux.ibm.com>
Reviewed-by: Steffen Maier <maier@linux.ibm.com>
Signed-off-by: Benjamin Block <bblock@linux.ibm.com>
---
 drivers/s390/scsi/zfcp_erp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/s390/scsi/zfcp_erp.c b/drivers/s390/scsi/zfcp_erp.c
index 79f6e8fb03ca..59e662df5774 100644
--- a/drivers/s390/scsi/zfcp_erp.c
+++ b/drivers/s390/scsi/zfcp_erp.c
@@ -68,7 +68,7 @@ static void zfcp_erp_action_ready(struct zfcp_erp_action *act)
 {
 	struct zfcp_adapter *adapter = act->adapter;
 
-	list_move(&act->list, &act->adapter->erp_ready_head);
+	list_move(&act->list, &adapter->erp_ready_head);
 	zfcp_dbf_rec_run("erardy1", act);
 	wake_up(&adapter->erp_ready_wq);
 	zfcp_dbf_rec_run("erardy2", act);
-- 
2.26.2

  parent reply	other threads:[~2020-07-03 13:21 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-03 13:19 [PATCH 0/7] zfcp: cleanups and small changes for 5.9 Benjamin Block
2020-07-03 13:19 ` [PATCH 1/7] zfcp: use prandom_u32_max() for backoff Benjamin Block
2020-07-03 13:19 ` [PATCH 2/7] zfcp: fix an outdated comment for zfcp_qdio_send() Benjamin Block
2020-07-03 13:19 ` [PATCH 3/7] scsi: docs: update outdated link to IBM developerworks Benjamin Block
2020-07-03 13:20 ` [PATCH 4/7] scsi: docs: remove invalid link and update text for zfcp kernel config Benjamin Block
2020-07-03 13:20 ` Benjamin Block [this message]
2020-07-03 13:20 ` [PATCH 6/7] zfcp: replace open-coded list move Benjamin Block
2020-07-03 13:20 ` [PATCH 7/7] zfcp: avoid benign overflow of the Request Queue's free-level Benjamin Block
2020-07-08  6:06 ` [PATCH 0/7] zfcp: cleanups and small changes for 5.9 Martin K. Petersen
2020-07-08 13:12   ` Benjamin Block

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d1bb04322f240dee32f4c4a551bc93bc736f4b01.1593780621.git.bblock@linux.ibm.com \
    --to=bblock@linux.ibm.com \
    --cc=borntraeger@de.ibm.com \
    --cc=gor@linux.ibm.com \
    --cc=heiko.carstens@de.ibm.com \
    --cc=jejb@linux.ibm.com \
    --cc=jwi@linux.ibm.com \
    --cc=linux-s390@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=loshakov@linux.ibm.com \
    --cc=maier@linux.ibm.com \
    --cc=martin.petersen@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox