public inbox for linux-s390@vger.kernel.org
 help / color / mirror / Atom feed
From: Matthew Rosato <mjrosato@linux.ibm.com>
To: Cai Huoqing <caihuoqing@baidu.com>,
	farman@linux.ibm.com, alex.williamson@redhat.com,
	cohuck@redhat.com
Cc: linux-s390@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: [PATCH v2] vfio-pci/zdev: Remove repeated verbose license text
Date: Tue, 24 Aug 2021 11:52:11 -0400	[thread overview]
Message-ID: <d2e299fb-c636-ea1d-a523-c0e842e0d9e6@linux.ibm.com> (raw)
In-Reply-To: <20210824003749.1039-1-caihuoqing@baidu.com>

On 8/23/21 8:37 PM, Cai Huoqing wrote:
> remove it because SPDX-License-Identifier is already used
> and change "GPL-2.0+" to "GPL-2.0-only"

Could maybe extend the commit message a little to add something along 
the lines of ' to match the more restrictive license that was specified 
by the verbose text being removed.', so as to explain why the identifier 
is being changed here.

With that,

Reviewed-by: Matthew Rosato <mjrosato@linux.ibm.com>

> 
> Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
> ---
> v1->v2: change "GPL-2.0+" to "GPL-2.0-only"
> 
>   drivers/vfio/pci/vfio_pci_zdev.c | 7 +------
>   1 file changed, 1 insertion(+), 6 deletions(-)
> 
> diff --git a/drivers/vfio/pci/vfio_pci_zdev.c b/drivers/vfio/pci/vfio_pci_zdev.c
> index 7b011b62c766..104fcf6658db 100644
> --- a/drivers/vfio/pci/vfio_pci_zdev.c
> +++ b/drivers/vfio/pci/vfio_pci_zdev.c
> @@ -1,15 +1,10 @@
> -// SPDX-License-Identifier: GPL-2.0+
> +// SPDX-License-Identifier: GPL-2.0-only
>   /*
>    * VFIO ZPCI devices support
>    *
>    * Copyright (C) IBM Corp. 2020.  All rights reserved.
>    *	Author(s): Pierre Morel <pmorel@linux.ibm.com>
>    *                 Matthew Rosato <mjrosato@linux.ibm.com>
> - *
> - * This program is free software; you can redistribute it and/or modify
> - * it under the terms of the GNU General Public License version 2 as
> - * published by the Free Software Foundation.
> - *
>    */
>   #include <linux/io.h>
>   #include <linux/pci.h>
> 


  reply	other threads:[~2021-08-24 15:52 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-24  0:37 [PATCH v2] vfio-pci/zdev: Remove repeated verbose license text Cai Huoqing
2021-08-24 15:52 ` Matthew Rosato [this message]
2021-08-24 16:18   ` Alex Williamson
2021-08-25  1:10     ` Cai Huoqing
2021-08-26 22:20 ` Alex Williamson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d2e299fb-c636-ea1d-a523-c0e842e0d9e6@linux.ibm.com \
    --to=mjrosato@linux.ibm.com \
    --cc=alex.williamson@redhat.com \
    --cc=caihuoqing@baidu.com \
    --cc=cohuck@redhat.com \
    --cc=farman@linux.ibm.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox