From: Pierre Morel <pmorel@linux.ibm.com>
To: Christian Borntraeger <borntraeger@de.ibm.com>,
David Hildenbrand <david@redhat.com>
Cc: linux-kernel@vger.kernel.org, cohuck@redhat.com,
linux-s390@vger.kernel.org, kvm@vger.kernel.org,
frankja@linux.ibm.com, akrowiak@linux.ibm.com,
schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com
Subject: Re: [PATCH] KVM: s390: vsie: Return correct values for Invalid CRYCB format
Date: Fri, 26 Apr 2019 12:48:17 +0200 [thread overview]
Message-ID: <d4cefe3e-1b53-82e0-10ef-326ac78f8fc8@linux.ibm.com> (raw)
In-Reply-To: <38c40ea1-9a7f-d720-a994-74c5bcee8e22@de.ibm.com>
On 26/04/2019 11:03, Christian Borntraeger wrote:
>
>
> On 26.04.19 11:01, David Hildenbrand wrote:
>> On 26.04.19 11:00, Pierre Morel wrote:
>>> Let's use the correct validity number.
>>>
>>> Fixes: 55ded154b43 "KVM: s390: vsie: Allow CRYCB FORMAT-2"
>>
>> LANG=c git show 55ded154b43
>> fatal: ambiguous argument '55ded154b43': unknown revision or path not in
>> the working tree.
>> Use '--' to separate paths from revisions, like this:
>>
>
> I think this should be
> 56019f9aca2266edc7f304d91e4e772023b7aa14
Yes it is, sorry, forgot to adjust the hash
>
>>
>>>
>>> Signed-off-by: Pierre Morel <pmorel@linux.ibm.com>
>>> Reviewed-by: Christian Borntraeger <borntraeger@de.ibm.com>
>>> ---
>>> arch/s390/kvm/vsie.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/arch/s390/kvm/vsie.c b/arch/s390/kvm/vsie.c
>>> index ac411e9..076090f 100644
>>> --- a/arch/s390/kvm/vsie.c
>>> +++ b/arch/s390/kvm/vsie.c
>>> @@ -344,7 +344,7 @@ static int shadow_crycb(struct kvm_vcpu *vcpu, struct vsie_page *vsie_page)
>>> end:
>>> switch (ret) {
>>> case -EINVAL:
>>> - return set_validity_icpt(scb_s, 0x0020U);
>>> + return set_validity_icpt(scb_s, 0x0022U);
>>> case -EFAULT:
>>> return set_validity_icpt(scb_s, 0x0035U);
>>> case -EACCES:
>>>
>>
>>
>
--
Pierre Morel
Linux/KVM/QEMU in Böblingen - Germany
next prev parent reply other threads:[~2019-04-26 10:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-26 9:00 [PATCH] KVM: s390: vsie: Return correct values for Invalid CRYCB format Pierre Morel
2019-04-26 9:01 ` David Hildenbrand
2019-04-26 9:03 ` Christian Borntraeger
2019-04-26 10:48 ` Pierre Morel [this message]
2019-04-26 9:07 ` David Hildenbrand
2019-04-26 10:54 ` Pierre Morel
2019-04-29 7:01 ` Christian Borntraeger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d4cefe3e-1b53-82e0-10ef-326ac78f8fc8@linux.ibm.com \
--to=pmorel@linux.ibm.com \
--cc=akrowiak@linux.ibm.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=heiko.carstens@de.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox