Re: [kvm-unit-tests PATCH 1/3] s390x: Add SPDX and header comments for s390x/* and lib/s390x/*

[Thomas Huth <thuth@redhat.com>]

On 28/07/2021 12.32, Claudio Imbrenda wrote:
> On Wed, 28 Jul 2021 10:13:26 +0000
> Janosch Frank <frankja@linux.ibm.com> wrote:
> 
>> Seems like I missed adding them.
>>
>> The s390x/sieve.c one is a bit of a head scratcher since it came with
>> the first commit but I assume it's lpgl2-only since that's what the
>> COPYRIGHT file said then.
>>
>> Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
>> ---
>>   lib/s390x/uv.c   |  9 +++++++++
>>   s390x/mvpg-sie.c |  9 +++++++++
>>   s390x/sie.c      | 10 ++++++++++
>>   x86/sieve.c      |  5 +++++
>>   4 files changed, 33 insertions(+)
[...]
>> diff --git a/x86/sieve.c b/x86/sieve.c
>> index 8150f2d9..b89d5f80 100644
>> --- a/x86/sieve.c
>> +++ b/x86/sieve.c
>> @@ -1,3 +1,8 @@
>> +/* SPDX-License-Identifier: LGPL-2.0-only */
> 
> do you really need to fix something in the x86 directory? (even though
> it is also used on other archs)

I just realized that s390x/sieve.c is just a symlink, not a copy of the file :-)

> maybe you can split out this as a separate patch, so s390x stuff is
> more self contained, and others can then discuss the sieve.c patch
> separately if needed?

That might make sense, indeed.

  Thomas