public inbox for linux-s390@vger.kernel.org
 help / color / mirror / Atom feed
From: Alexander Gordeev <agordeev@linux.ibm.com>
To: Maninder Singh <maninder1.s@samsung.com>
Cc: hca@linux.ibm.com, gor@linux.ibm.com, borntraeger@linux.ibm.com,
	svens@linux.ibm.com, linux-s390@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] s390: remove extra check of task_stack_page()
Date: Tue, 28 Apr 2026 15:31:52 +0200	[thread overview]
Message-ID: <d61c9efe-7639-4520-b15a-ae0c19f418b3-agordeev@linux.ibm.com> (raw)
In-Reply-To: <20260428105607.1283661-1-maninder1.s@samsung.com>

On Tue, Apr 28, 2026 at 04:26:07PM +0530, Maninder Singh wrote:
> There is no need to call task_stack_page(),
> because try_get_task_stack() already takes care of that.
> 
> Signed-off-by: Maninder Singh <maninder1.s@samsung.com>
> ---
>  arch/s390/kernel/process.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/arch/s390/kernel/process.c b/arch/s390/kernel/process.c
> index 0df95dcb2101..dabd569dbba8 100644
> --- a/arch/s390/kernel/process.c
> +++ b/arch/s390/kernel/process.c
> @@ -203,9 +203,6 @@ unsigned long __get_wchan(struct task_struct *p)
>  	struct unwind_state state;
>  	unsigned long ip = 0;
>  
> -	if (!task_stack_page(p))
> -		return 0;
> -
>  	if (!try_get_task_stack(p))
>  		return 0;

Applied, thanks!

      parent reply	other threads:[~2026-04-28 13:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20260428105633epcas5p37a93b7abb3d2ce0d1c2fbf6a72634ea7@epcas5p3.samsung.com>
2026-04-28 10:56 ` [PATCH 1/1] s390: remove extra check of task_stack_page() Maninder Singh
2026-04-28 12:54   ` Heiko Carstens
2026-04-28 13:31   ` Alexander Gordeev [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d61c9efe-7639-4520-b15a-ae0c19f418b3-agordeev@linux.ibm.com \
    --to=agordeev@linux.ibm.com \
    --cc=borntraeger@linux.ibm.com \
    --cc=gor@linux.ibm.com \
    --cc=hca@linux.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=maninder1.s@samsung.com \
    --cc=svens@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox