From: Helge Deller <deller@gmx.de>
To: Masahiro Yamada <masahiroy@kernel.org>, linux-kbuild@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org,
linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org,
linux-s390@vger.kernel.org, linux-um@lists.infradead.org,
loongarch@lists.linux.dev, sparclinux@vger.kernel.org,
x86@kernel.org,
"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>
Subject: Re: [PATCH 3/5] parisc: remove broken vdso_install
Date: Thu, 12 Oct 2023 09:24:36 +0200 [thread overview]
Message-ID: <d886d83a-87b4-428d-856e-9bbaa554563a@gmx.de> (raw)
In-Reply-To: <20231009124210.1064021-3-masahiroy@kernel.org>
Hi Masahiro,
On 10/9/23 14:42, Masahiro Yamada wrote:
> 'make ARCH=parisc vdso_install' has never worked. It attempts to
> descend into arch/parisc/kernel/vdso/, which does not exist.
>
> The command just fails:
>
> scripts/Makefile.build:41: arch/parisc/kernel/vdso/Makefile: No such file or directory
>
> The second line is also meaningless because parisc does not define
> CONFIG_COMPAT_VDSO.
>
> It appears that this code was copied from another architecture without
> proper adaptation.
Yes.
> Remove the broken code.
>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Thanks for cleaning this up and making it consistent across the architectures.
Acked-by: Helge Deller <deller@gmx.de> # parisc
In case you do a v2 version of the patch, would you add to arch/parisc/Makefile
(otherwise I can send a follow-up patch in the parisc git tree):
vdso-install-y += arch/parisc/kernel/vdso32/vdso32.so
vdso-install-$(CONFIG_64BIT) += arch/parisc/kernel/vdso64/vdso64.so
Thanks!
Helge
next prev parent reply other threads:[~2023-10-12 7:25 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-09 12:42 [PATCH 1/5] csky: remove unused cmd_vdso_install Masahiro Yamada
2023-10-09 12:42 ` [PATCH 2/5] UML: " Masahiro Yamada
2023-10-09 13:09 ` Richard Weinberger
2023-10-09 12:42 ` [PATCH 3/5] parisc: remove broken vdso_install Masahiro Yamada
2023-10-12 7:24 ` Helge Deller [this message]
2023-10-09 12:42 ` [PATCH 4/5] kbuild: unify vdso_install rules Masahiro Yamada
2023-10-10 7:36 ` Sven Schnelle
2023-10-11 2:23 ` Guo Ren
2023-10-11 12:52 ` Masahiro Yamada
2023-10-12 6:21 ` Guo Ren
2023-10-11 20:10 ` Nicolas Schier
2023-10-27 19:48 ` Russell King (Oracle)
2023-10-09 12:42 ` [PATCH 5/5] kbuild: unify no-compiler-targets and no-sync-config-targets Masahiro Yamada
2023-10-09 16:44 ` Nathan Chancellor
2023-10-14 8:41 ` Masahiro Yamada
2023-10-09 15:16 ` [PATCH 1/5] csky: remove unused cmd_vdso_install Guo Ren
2023-10-14 9:08 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d886d83a-87b4-428d-856e-9bbaa554563a@gmx.de \
--to=deller@gmx.de \
--cc=James.Bottomley@HansenPartnership.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-csky@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-um@lists.infradead.org \
--cc=loongarch@lists.linux.dev \
--cc=masahiroy@kernel.org \
--cc=sparclinux@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox