From: Christian Borntraeger <borntraeger@de.ibm.com>
To: Cornelia Huck <cohuck@redhat.com>,
Farhan Ali <alifm@linux.ibm.com>,
Eric Farman <farman@linux.ibm.com>
Cc: Heiko Carstens <heiko.carstens@de.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
Halil Pasic <pasic@linux.ibm.com>,
linux-s390@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: [PATCH] vfio-ccw: make convert_ccw0_to_ccw1 static
Date: Mon, 24 Jun 2019 13:55:03 +0200 [thread overview]
Message-ID: <dceaeaf9-b961-c4c7-45e5-d8dc31b68b31@de.ibm.com> (raw)
In-Reply-To: <20190624090721.16241-1-cohuck@redhat.com>
On 24.06.19 11:07, Cornelia Huck wrote:
> Reported by sparse.
>
> Fixes: 7f8e89a8f2fd ("vfio-ccw: Factor out the ccw0-to-ccw1 transition")
> Signed-off-by: Cornelia Huck <cohuck@redhat.com>
> ---
> On top of my vfio-ccw branch.
>
> s390 arch maintainers: let me know if I should queue it and send
> a pull request, or if you prefer to apply it directly.
I still have to sort out some tooling for the s390 tree and I applied it directly.
Thanks
> ---
> drivers/s390/cio/vfio_ccw_cp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/s390/cio/vfio_ccw_cp.c b/drivers/s390/cio/vfio_ccw_cp.c
> index 9cddc1288059..a7b9dfd5b464 100644
> --- a/drivers/s390/cio/vfio_ccw_cp.c
> +++ b/drivers/s390/cio/vfio_ccw_cp.c
> @@ -161,7 +161,7 @@ static inline void pfn_array_idal_create_words(
> idaws[0] += pa->pa_iova & (PAGE_SIZE - 1);
> }
>
> -void convert_ccw0_to_ccw1(struct ccw1 *source, unsigned long len)
> +static void convert_ccw0_to_ccw1(struct ccw1 *source, unsigned long len)
> {
> struct ccw0 ccw0;
> struct ccw1 *pccw1 = source;
>
prev parent reply other threads:[~2019-06-24 11:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-24 9:07 [PATCH] vfio-ccw: make convert_ccw0_to_ccw1 static Cornelia Huck
2019-06-24 11:55 ` Christian Borntraeger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dceaeaf9-b961-c4c7-45e5-d8dc31b68b31@de.ibm.com \
--to=borntraeger@de.ibm.com \
--cc=alifm@linux.ibm.com \
--cc=cohuck@redhat.com \
--cc=farman@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=heiko.carstens@de.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=pasic@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox