From: Collin Walling <walling@linux.ibm.com>
To: Christian Borntraeger <borntraeger@de.ibm.com>,
David Hildenbrand <david@redhat.com>,
cohuck@redhat.com, pbonzini@redhat.com, kvm@vger.kernel.org,
linux-s390@vger.kernel.org
Subject: Re: [PATCH v5 2/2] s390/kvm: diagnose 318 handling
Date: Wed, 26 Jun 2019 10:30:08 -0400 [thread overview]
Message-ID: <dd1f4c39-9937-b223-adc8-01a764cf9462@linux.ibm.com> (raw)
In-Reply-To: <17fe3423-91b1-2351-54cb-26cd9e1b0e3f@de.ibm.com>
On 6/26/19 6:28 AM, Christian Borntraeger wrote:
>
>
> On 26.06.19 11:45, David Hildenbrand wrote:
>
>>
>> BTW. there is currently no mechanism to fake absence of diag318. Should
>> we have one? (in contrast, for CMMA we have, which is also a CPU feature)
>
> Yes, we want to be able to disable diag318 via a CPU model feature. That actually
> means that the kernel must not answer this if we disable it.
>
Correct. If the guest specifies diag318=off, then the instruction
shouldn't be executed (it is fenced off in the kernel by checking the
Read SCP Info bit).
next prev parent reply other threads:[~2019-06-26 14:30 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-25 15:03 [PATCH v5 0/2] Use DIAG318 to set Control Program Name & Version Codes Collin Walling
2019-06-25 15:03 ` [PATCH v5 1/2] s390/setup: diag318: refactor struct Collin Walling
2019-06-26 11:42 ` Cornelia Huck
2019-06-25 15:03 ` [PATCH v5 2/2] s390/kvm: diagnose 318 handling Collin Walling
2019-06-26 9:08 ` David Hildenbrand
2019-06-26 13:57 ` Collin Walling
2019-06-26 9:45 ` David Hildenbrand
2019-06-26 10:28 ` Christian Borntraeger
2019-06-26 14:30 ` Collin Walling [this message]
2019-06-26 14:31 ` David Hildenbrand
2019-07-02 19:50 ` Collin Walling
2019-07-02 20:00 ` Christian Borntraeger
2019-07-02 20:04 ` Collin Walling
2019-07-02 20:08 ` Christian Borntraeger
2019-06-26 12:11 ` Cornelia Huck
2019-06-26 13:51 ` Collin Walling
2019-06-25 15:20 ` [PATCH v5 0/2] Use DIAG318 to set Control Program Name & Version Codes Collin Walling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dd1f4c39-9937-b223-adc8-01a764cf9462@linux.ibm.com \
--to=walling@linux.ibm.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox